-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BatchInsert is translated incorrectly for Oracle custom changes #1613
Comments
Hi @cdprete Thanks for writing up this issue. |
Hi @molivasdat What I'm doing is essentially to implement a https://www.javadoc.io/static/org.liquibase/liquibase-core/3.6.0/liquibase/change/custom/CustomSqlChange.html that returns an array of https://www.javadoc.io/static/org.liquibase/liquibase-core/3.6.0/liquibase/statement/core/InsertSetStatement.html where, of course, every InsertSetStatement has multiple https://www.javadoc.io/static/org.liquibase/liquibase-core/3.6.0/liquibase/statement/core/InsertStatement.html. This works fine for Postgres, but with Oracle the DML above is generated as well which is unsupported. |
Thanks @cdprete for the additional description. We will add this to the list of issues to process. We typically do not go back in versions for updates at least on the community version. Would it be a problem to update the latest version to get something fixed? |
Hi @molivasdat. |
Hi @molivasdat. |
Hi @cdprete I don't have a PR or fix yet for this. If you have suggested fix that might help move it along faster. |
Hello @cdprete, sorry for the late response, we're going through our ticket backlog and testing these issues. |
Hi @tati-qalified. Not anymore since almost 2y have passed :D |
That's fair, thank you anyway! |
Liquibase Integration: Spring Boot 2.1.2
Database Vendor & Version: Oracle 12
Description
When creating a custom change that implies the usage of InsertSetStatement for performing multiple insertions at once, the InsertSetGenerator#supports method returns
true
for Oracle, but the statement that's generated is invalid.INSERT INTO XYZ(X,Y,Z) VALUES(...),...,(...)
is generated rather than something like in https://stackoverflow.com/a/39602The text was updated successfully, but these errors were encountered: