Double unsigned cannot be created in MySQL.

[ThisOldDog]

Environment

Liquibase Version: 4.5.0

Liquibase Integration & Version: maven

<dependency>
  <groupId>org.liquibase</groupId>
  <artifactId>liquibase-core</artifactId>
  <version>4.5.0</version>
</dependency>

Description

Double unsigned cannot be created in MySQL, unsigned additional information is lost.

Steps To Reproduce

Create a table in ChangeSet, specify the column type as double(32,0) unsigned: liquibase.datatype.core.DoubleType

Actual Behavior

As you can see, the Double type DatabaseDataType is created, but additionalInformation = unsigned is lost (Is this a bug?).

Expected/Desired Behavior

additionalInformation can be added to DatabaseDataType, such as (The example only fixes MySQL)：

if (database instanceof MySQLDatabase) {
    DatabaseDataType databaseDataType;
    if ((getParameters() != null) && (getParameters().length > 1)) {
        databaseDataType =  new DatabaseDataType("DOUBLE", getParameters());
    } else {
        databaseDataType = new DatabaseDataType("DOUBLE");
    }
    databaseDataType.addAdditionalInformation(getAdditionalInformation());
    return databaseDataType;
}

Additional Context

Any help would be appreciated 😃.

[molivasdat]

Hi @ThisOldDog Thanks for showing us this issue. Can you also add a changeset that shows the issue that you are describing? We will add this to the list of issues that we are processing.

[ThisOldDog]

Hi @ThisOldDog Thanks for showing us this issue. Can you also add a changeset that shows the issue that you are describing? We will add this to the list of issues that we are processing.

Thank you for your reply. The test example is as follows:

{
    "databaseChangeLog": [
        {
            "logicalFilePath": "21cec2ff6c90427e9b6d0c27cffcc1fb.custom",
            "changeSet": {
                "changes": [
                    {
                        "createTable": {
                            "columns": [
                                {
                                    "column": {
                                        "name": "DOUBLE_COLUMN",
                                        "type": "double(38,2) unsigned",
                                        "remarks": "double_unsigned"
                                    }
                                },
                                {
                                    "column": {
                                        "name": "ID",
                                        "type": "bigint(19)",
                                        "constraints": {
                                            "primaryKeyName": "test_double_pk"
                                        },
                                        "remarks": "PK"
                                    }
                                }
                            ],
                            "tableName": "test_double"
                        }
                    },
                    {
                        "sql": {
                            "stripComments": false,
                            "splitStatements": false,
                            "sql": " ALTER TABLE test_double MODIFY COLUMN ID BIGINT(19) NOT NULL  COMMENT 'PK' AUTO_INCREMENT "
                        }
                    }
                ],
                "id": "2021-11-17_test_double",
                "author": "12706"
            }
        }
    ]
}

[nvoxland]

Thanks, @ThisOldDog. I used your suggested code in #2293