database changelog history record-keeping (DAT-16178) #5147

StevenMassaro · 2023-11-01T14:26:49Z

Impact

Bug fix (non-breaking change which fixes expected existing functionality)
Enhancement/New feature (adds functionality without impacting existing logic)
Breaking change (fix or feature that would cause existing functionality to change)

Description

The current DBCL tracks changes currently applied to a db, but when changes are rolledback, these changeset records dissappear. This new PRO table, DATABASECHANGELOGHISTORY, will track all changes made and rolled back and dropped. The overall goal of this table is track the history of database changing liquibase operations, including rollbacks, dropall, repeated updates of the same changeset, etc.

Things to be aware of

Things to worry about

Additional Context

…s from factory (DAT-15985) (#5123)

…15798) (#5146)

…rategy method (#5160)

liquibase-standard/src/main/java/liquibase/command/CommandFailedException.java

@@ -23,7 +25,7 @@
        return results;
    }

-    public int getExitCode() {
+    public Integer getExitCode() {


liquibase-standard/src/main/java/liquibase/exception/UnexpectedLiquibaseException.java

    private static final long serialVersionUID = 1570124571347160550L;
+    private Integer exitCode = null;


liquibase-cli/src/main/java/liquibase/integration/commandline/VersionUtils.java

+        return null;
+    }
+
+    public static class LibraryInfo implements Comparable<LibraryInfo> {


…ing history table (DAT-15973) (#5203)

liquibase-standard/src/main/java/liquibase/changelog/visitor/ChangeLogSyncListener.java

@@ -7,4 +7,7 @@
 public interface ChangeLogSyncListener {
    void markedRan(ChangeSet changeSet, DatabaseChangeLog databaseChangeLog, Database database);

+    default void markedRanFailed(ChangeSet changeSet, DatabaseChangeLog databaseChangeLog, Database database, Exception e) {


liquibase-standard/src/main/java/liquibase/changelog/visitor/ChangeLogSyncListener.java

@@ -7,4 +7,7 @@
 public interface ChangeLogSyncListener {
    void markedRan(ChangeSet changeSet, DatabaseChangeLog databaseChangeLog, Database database);

+    default void markedRanFailed(ChangeSet changeSet, DatabaseChangeLog databaseChangeLog, Database database, Exception e) {


liquibase-standard/src/main/java/liquibase/changelog/visitor/ChangeLogSyncListener.java

@@ -7,4 +7,7 @@
 public interface ChangeLogSyncListener {
    void markedRan(ChangeSet changeSet, DatabaseChangeLog databaseChangeLog, Database database);

+    default void markedRanFailed(ChangeSet changeSet, DatabaseChangeLog databaseChangeLog, Database database, Exception e) {


liquibase-standard/src/main/java/liquibase/changelog/visitor/ChangeLogSyncListener.java

@@ -7,4 +7,7 @@
 public interface ChangeLogSyncListener {
    void markedRan(ChangeSet changeSet, DatabaseChangeLog databaseChangeLog, Database database);

+    default void markedRanFailed(ChangeSet changeSet, DatabaseChangeLog databaseChangeLog, Database database, Exception e) {


sonarcloud · 2023-11-14T20:04:34Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

39.5% Coverage
1.3% Duplication

…5224)

liquibase-standard/src/main/java/liquibase/command/core/DropAllCommandStep.java

@@ -83,6 +89,11 @@
        resultsBuilder.addResult("statusCode", 0);
    }

+    public SnapshotControl getSnapshotControl(CommandScope commandScope, Database database) {


liquibase-standard/src/main/java/liquibase/command/core/DropAllCommandStep.java

@@ -83,6 +89,11 @@
        resultsBuilder.addResult("statusCode", 0);
    }

+    public SnapshotControl getSnapshotControl(CommandScope commandScope, Database database) {


…5375) add dbcl-history configuration options to maven plugin

# Conflicts: # liquibase-standard/src/main/java/liquibase/command/CommandScope.java # liquibase-standard/src/main/java/liquibase/database/Database.java

# Conflicts: # liquibase-cli/src/main/java/liquibase/integration/commandline/LiquibaseCommandLine.java

liquibase-maven-plugin/src/main/java/org/liquibase/maven/plugins/LiquibaseDbclHistoryMojo.java

+     * @parameter property="liquibase.verbose"
+     */
+    @PropertyElement
+    protected Boolean verbose;


add maven arguments to scope

…en (DAT-16881) (#5609) fix dbclHistoryEnabled property from liquibase.properties file in maven

record executed SQL in ChangelogJdbcMdcListener

liquibase-standard/src/main/java/liquibase/database/Database.java

+    default void addCompleteSqlToScope(String completeSql) {
+        AtomicReference<String> sqlsReference = Scope.getCurrentScope().get(COMPLETE_SQL_SCOPE_KEY, AtomicReference.class);
+        if (sqlsReference != null) {
+            sqlsReference.set(completeSql.toString());


…0) (#5651) * add captureExtensions and captureSql params to maven plugin * update javadoc * additional javadoc fixes

override dependency providing command steps, get liquibase table name…

e12fb08

…s from factory (DAT-15985) (#5123)

StevenMassaro added the TypeEnhancement label Nov 1, 2023

StevenMassaro added 5 commits November 3, 2023 08:27

Merge branch 'master' into DAT-16178

ffb7cab

Merge branch 'master' into DAT-16178

88c304c

Merge branch 'master' into DAT-16178

2c9d215

changes in support of history table logging of rollback command (DAT-…

0ab5cce

…15798) (#5146)

optionally add to rowsAffected count, add temporary object quoting st…

c9eb706

…rategy method (#5160)

github-advanced-security bot found potential problems Nov 14, 2023

View reviewed changes

additions to ChangeLogSyncListener (and others) in support of populat…

2a7a7d4

…ing history table (DAT-15973) (#5203)

github-advanced-security bot found potential problems Nov 14, 2023

View reviewed changes

Merge branch 'master' into DAT-16178

f41b786

StevenMassaro and others added 3 commits November 16, 2023 12:10

Merge branch 'master' into DAT-16178

7088453

Merge branch 'master' into DAT-16178

e487266

changes in support of recording dropAll in history table (DAT-16148) (#…

b95a84e

…5224)

github-advanced-security bot found potential problems Nov 27, 2023

View reviewed changes

StevenMassaro and others added 3 commits December 7, 2023 08:00

Merge branch 'master' into DAT-16178

a1d598a

Merge branch 'master' into DAT-16178

22afa36

Merge remote-tracking branch 'origin/master' into DAT-16178

527a49b

abrackx temporarily deployed to internal December 14, 2023 18:18 — with GitHub Actions Inactive

abrackx temporarily deployed to internal December 15, 2023 19:53 — with GitHub Actions Inactive

move helper method to utils class (DAT-16212) (#5342)

f0e6f8e

StevenMassaro temporarily deployed to internal December 19, 2023 13:51 — with GitHub Actions Inactive

add dbcl-history configuration options to maven plugin (DAT-16280) (#…

fdcc7f1

…5375) add dbcl-history configuration options to maven plugin

suryaaki2 temporarily deployed to internal December 21, 2023 20:17 — with GitHub Actions Inactive

Merge branch 'master' into DAT-16178

06fa6c4

# Conflicts: # liquibase-standard/src/main/java/liquibase/command/CommandScope.java # liquibase-standard/src/main/java/liquibase/database/Database.java

StevenMassaro temporarily deployed to internal January 9, 2024 19:36 — with GitHub Actions Inactive

clear MDC after each test run

0317a5b

StevenMassaro temporarily deployed to internal January 9, 2024 20:52 — with GitHub Actions Inactive

Merge branch 'master' into DAT-16178

2e1a050

# Conflicts: # liquibase-cli/src/main/java/liquibase/integration/commandline/LiquibaseCommandLine.java

github-advanced-security bot found potential problems Feb 12, 2024

View reviewed changes

Merge branch 'master' into DAT-16178

2efc8d2

StevenMassaro temporarily deployed to internal February 13, 2024 13:23 — with GitHub Actions Inactive

StevenMassaro temporarily deployed to internal February 13, 2024 13:55 — with GitHub Actions Inactive

Merge branch 'master' into DAT-16178

df7eb12

StevenMassaro temporarily deployed to internal February 19, 2024 20:31 — with GitHub Actions Inactive

add maven arguments to scope (DAT-16921) (#5605)

a5f3dcb

add maven arguments to scope

suryaaki2 temporarily deployed to internal February 21, 2024 22:01 — with GitHub Actions Inactive

suryaaki2 temporarily deployed to internal February 23, 2024 09:02 — with GitHub Actions Inactive

Merge branch 'master' into DAT-16178

2adc448

StevenMassaro temporarily deployed to internal February 26, 2024 14:51 — with GitHub Actions Inactive

StevenMassaro temporarily deployed to internal February 26, 2024 16:11 — with GitHub Actions Inactive

fix dbclHistoryEnabled property from liquibase.properties file in mav…

7a1e556

…en (DAT-16881) (#5609) fix dbclHistoryEnabled property from liquibase.properties file in maven

suryaaki2 temporarily deployed to internal February 26, 2024 20:11 — with GitHub Actions Inactive

record executed SQL in ChangelogJdbcMdcListener (DAT-16886) (#5620)

9bdc430

record executed SQL in ChangelogJdbcMdcListener

suryaaki2 temporarily deployed to internal February 27, 2024 15:22 — with GitHub Actions Inactive

github-advanced-security bot found potential problems Feb 27, 2024

View reviewed changes

suryaaki2 temporarily deployed to internal March 1, 2024 17:34 — with GitHub Actions Inactive

add captureExtensions and captureSql params to maven plugin (DAT-1698…

fb71318

…0) (#5651) * add captureExtensions and captureSql params to maven plugin * update javadoc * additional javadoc fixes

suryaaki2 temporarily deployed to internal March 5, 2024 14:46 — with GitHub Actions Inactive

Merge branch 'master' into DAT-16178

772078c

rberezen temporarily deployed to internal March 13, 2024 17:57 — with GitHub Actions Inactive

rberezen temporarily deployed to internal March 14, 2024 17:16 — with GitHub Actions Inactive

rberezen temporarily deployed to internal March 14, 2024 22:34 — with GitHub Actions Inactive

rberezen temporarily deployed to internal March 18, 2024 15:33 — with GitHub Actions Inactive

StevenMassaro marked this pull request as ready for review March 19, 2024 13:55

StevenMassaro requested a review from filipelautert as a code owner March 19, 2024 13:55

filipelautert approved these changes Mar 19, 2024

View reviewed changes

StevenMassaro merged commit 547e54a into master Mar 19, 2024
33 of 35 checks passed

StevenMassaro deleted the DAT-16178 branch March 19, 2024 14:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

database changelog history record-keeping (DAT-16178) #5147

database changelog history record-keeping (DAT-16178) #5147

StevenMassaro commented Nov 1, 2023 •

edited

sonarcloud bot commented Nov 14, 2023

		private static final long serialVersionUID = 1570124571347160550L;
		private Integer exitCode = null;

database changelog history record-keeping (DAT-16178) #5147

database changelog history record-keeping (DAT-16178) #5147

Conversation

StevenMassaro commented Nov 1, 2023 • edited

Impact

Description

Things to be aware of

Things to worry about

Additional Context

sonarcloud bot commented Nov 14, 2023

StevenMassaro commented Nov 1, 2023 •

edited