add default constructor + setters to RanChangeSet & related classes
#5336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is needed to be able to de-serialise them using [jackson] which relies on the default constructor & setters. in the upcoming liquibase-opensearch implementation [opensearch-java] is used, which underneath is using jackson for the (de-)serialisation of classes. specifically, this is used in the implementation of `AbstractChangeLogHistoryService#queryRanChangeSets` which needs to load `RanChangeSet`s from the DB. also do some minor cleanups by removing manually implemented getters & setters where lombok annotations can do the job instead (no functional impact). [jackson]: https://github.com/FasterXML/jackson [opensearch-java]: https://github.com/opensearch-project/opensearch-java/ Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com>
MalloD12
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
Approved.
Code changes look good to me.
FYI @rursprung, someone from the team will be meeting soon with Nathan to get some guidance and be able to help you with your questions.
Thanks,
Daniel.
rberezen
approved these changes
Jan 5, 2024
filipelautert
approved these changes
Jan 15, 2024
rursprung
added a commit
to rursprung/liquibase
that referenced
this pull request
May 27, 2024
this is needed to be able to de-serialise it using [jackson] which relies on the default constructor & setters. in the upcoming [liquibase-opensearch] implementation [opensearch-java] is used, which underneath is using jackson for the (de-)serialisation of classes. specifically, this is used in the implementation of `LockService#listLocks` which needs to load `DatabaseChangeLogLock`s from the DB. also do some minor cleanups by removing manually implemented getters & setters where lombok annotations can do the job instead (no functional impact). this could be cleaned up even further if `Date` were replaced with `LocalTime` (which is immutable), but that'd be a bigger (breaking) change. note that this is the same pattern as was previously done in liquibase#5336 (commit b4726a0) for `RanChangeSet` & other classes. [jackson]: https://github.com/FasterXML/jackson [opensearch-java]: https://github.com/opensearch-project/opensearch-java/ [liquibase-opensearch]: https://github.com/liquibase/liquibase-opensearch/ Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com>
3 tasks
rursprung
added a commit
to rursprung/liquibase
that referenced
this pull request
May 28, 2024
this is needed to be able to de-serialise it using [jackson] which relies on the getters. in the upcoming [liquibase-opensearch] implementation [opensearch-java] is used, which underneath is using jackson for the (de-)serialisation of classes. this is a follow-up to commit 3823f0b (PR liquibase#5336) where only the deserialisation was fixed (by adding a default constructor + setters). [jackson]: https://github.com/FasterXML/jackson [opensearch-java]: https://github.com/opensearch-project/opensearch-java/ [liquibase-opensearch]: https://github.com/liquibase/liquibase-opensearch/
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
this is needed to be able to de-serialise them using jackson which relies on the default constructor & setters.
in the upcoming liquibase-opensearch implementation opensearch-java is used, which underneath is using jackson for the (de-)serialisation of classes.
specifically, this is used in the implementation of
AbstractChangeLogHistoryService#queryRanChangeSetswhich needs to loadRanChangeSets from the DB.also do some minor cleanups by removing manually implemented getters & setters where lombok annotations can do the job instead (no functional impact).
Things to be aware of
n/a
Things to worry about
n/a
Additional Context
for liquibase-opensearch see #4236 & opensearch-project/opensearch-migrations#148 (btw: still waiting for a reply from @nvoxland there! if you have any way of pinging him to get his feedback there that'd be great)