-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2352 by adding support for loading embedded jar files #5340
Conversation
…to hayeskl-embeddedJar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hayeskl for submitting this PR. Only question I have is shouldn't these code changes be extended to DirectoryResourceAccessor
and DirectoryPathHandler
as well?
Other than that code changes look good to me. Build and tests have been successfully executed.
Thanks,
Daniel.
I do not believe those have the same issue. In my testing I could load the migrations from the filesystem just fine, but when I tried loading the migrations from an embedded jar that is when it didn't work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Build and tests have been executed successfully, except for functional test which are failing due to an unknown issue trying to download artifacts.
Tests are successful, with one exception unrelated to the code changes. Thank you, @hayeskl, for your contribution. |
Impact
Description
Fixes #2352 so that embedded.jar files containing the changelog directory will once again work with includeAll. The issue was that the path passed into ZipResourceAccessor was stripping off the embedded path and need the extra path elements passed in to load the filesystem correctly.
Things to be aware of
Things to worry about
Additional Context