Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2352 by adding support for loading embedded jar files #5340

Merged
merged 5 commits into from
Jan 12, 2024

Conversation

hayeskl
Copy link
Contributor

@hayeskl hayeskl commented Dec 8, 2023

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fixes #2352 so that embedded.jar files containing the changelog directory will once again work with includeAll. The issue was that the path passed into ZipResourceAccessor was stripping off the embedded path and need the extra path elements passed in to load the filesystem correctly.

Things to be aware of

Things to worry about

Additional Context

@MalloD12 MalloD12 requested a deployment to external December 26, 2023 23:46 — with GitHub Actions Abandoned
@MalloD12 MalloD12 changed the base branch from master to 4.4.x December 27, 2023 15:16
@MalloD12 MalloD12 changed the base branch from 4.4.x to master December 27, 2023 15:17
@MalloD12 MalloD12 requested a deployment to external December 27, 2023 15:24 — with GitHub Actions Abandoned
Copy link
Contributor

@MalloD12 MalloD12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hayeskl for submitting this PR. Only question I have is shouldn't these code changes be extended to DirectoryResourceAccessor and DirectoryPathHandler as well?

Other than that code changes look good to me. Build and tests have been successfully executed.

Thanks,
Daniel.

@MalloD12 MalloD12 self-assigned this Dec 28, 2023
@hayeskl
Copy link
Contributor Author

hayeskl commented Jan 2, 2024

Thanks @hayeskl for submitting this PR. Only question I have is shouldn't these code changes be extended to DirectoryResourceAccessor and DirectoryPathHandler as well?

Other than that code changes look good to me. Build and tests have been successfully executed.

Thanks, Daniel.

I do not believe those have the same issue. In my testing I could load the migrations from the filesystem just fine, but when I tried loading the migrations from an embedded jar that is when it didn't work.

Copy link
Contributor

@MalloD12 MalloD12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Build and tests have been executed successfully, except for functional test which are failing due to an unknown issue trying to download artifacts.

@rberezen
Copy link
Contributor

rberezen commented Jan 8, 2024

Tests are successful, with one exception unrelated to the code changes. Thank you, @hayeskl, for your contribution.

@filipelautert filipelautert added this to the 1NEXT milestone Jan 12, 2024
@filipelautert filipelautert merged commit c60a897 into liquibase:master Jan 12, 2024
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

includeAll cannot process directories in embedded jar files
5 participants