Moved saved_state/compareGenerateSql.. directory from java source to resources bundle

[MalloD12]

As discussed recently to avoid confusion on people we have decided to move saved_state/compareGeneratedSqlWithExpectedSqlForMinimalChangesets SQL files from the java source directory and place them all in the resources bundle.

Fixes #5335

Impact

• Bug fix (non-breaking change which fixes expected existing functionality)
• Enhancement/New feature (adds functionality without impacting existing logic)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

• None

Things to worry about

• None

Additional Context

[MalloD12]

@tati-qalified - @rursprung Guys when you have a chance, could you please try pulling this branch and then running either mvn clean install or mvn test and then run git status to see whether you are getting all these files untracked. After moving them to the resources bundle I don't see them changed after running any of these mvn commands.

Thanks,
Daniel.

[filipelautert]

Hey @MalloD12 - don't you need to change the path at AbstractVerifyTest.java:39 to point to this new path?

[MalloD12]

Hey @MalloD12 - don't you need to change the path at AbstractVerifyTest.java:39 to point to this new path?

Yeap, I think you are right @filipelautert. I didn't update it because all tests were successfully passing, but it makes total sense to update that path. I'll do it and make sure all tests keep passing.

Thanks,
Daniel.

[MalloD12]

Hey @MalloD12 - don't you need to change the path at AbstractVerifyTest.java:39 to point to this new path?

Done!

[tati-qalified]

@MalloD12 tested - seems to work as expected!
Here's the output of running mvn test and git status:

[rursprung]

i guess in this case i don't need to try this as well since it should reproduce the same way for all of us? :)