prevent multiple databases in test classes #5457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenMassaro
temporarily deployed
to
internal
GitHub Actions
Inactive
StevenMassaro
force-pushed
the
prevent-multiple-databases-in-tests
branch
from
71c95a5
to
1ea59a4
Compare
StevenMassaro
temporarily deployed
to
internal
GitHub Actions
Inactive
abrackx
approved these changes
Jan 11, 2024
StevenMassaro
temporarily deployed
to
internal
GitHub Actions
Inactive
StevenMassaro
temporarily deployed
to
internal
GitHub Actions
Inactive
filipelautert
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Due to a combination of the logic in
liquibase-extension-testingused to determine whether a particular test class matches the specified databases, and the fact that the integration tests run in a matrix in GHA, test classes with more than oneDatabaseTestSystemspecified will not run on any platform in GHA. This PR prevents someone from accidentally creating a test class that has more than oneDatabaseTestSystem.Things to be aware of
Things to worry about
Additional Context