Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing OSGI settings #5498

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Add missing OSGI settings #5498

merged 1 commit into from
Jan 30, 2024

Conversation

filipelautert
Copy link
Collaborator

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fixes #5357

@filipelautert filipelautert self-assigned this Jan 23, 2024
@filipelautert filipelautert marked this pull request as ready for review January 23, 2024 15:32
@filipelautert filipelautert mentioned this pull request Jan 23, 2024
Closed
2 tasks
@filipelautert filipelautert requested a deployment to internal January 23, 2024 17:06 — with GitHub Actions Abandoned
@rberezen
Copy link
Contributor

@filipelautert could you please inspect the test failure?

@filipelautert filipelautert requested a deployment to internal January 23, 2024 18:49 — with GitHub Actions Abandoned
@filipelautert
Copy link
Collaborator Author

@filipelautert could you please inspect the test failure?

@rberezen that's the new test from master that randomly fails on windows. We need to rerun until it works :(

@filipelautert
Copy link
Collaborator Author

@rberezen all building now! and here is testing evidence in an OSGI environment: #5357 (comment)

@filipelautert filipelautert added this to the 1NEXT milestone Jan 30, 2024
@filipelautert filipelautert merged commit d2d71a9 into master Jan 30, 2024
32 checks passed
@filipelautert filipelautert deleted the fix-osgi-service-loader branch January 30, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rberezen rberezen rberezen approved these changes

@MalloD12 MalloD12 MalloD12 approved these changes

@suryaaki2 suryaaki2 Awaiting requested review from suryaaki2

Assignees

@filipelautert filipelautert

Labels
TypeBug
Projects
Liquibase Open Source
Status: Done
Milestone
v4.26.0
Development

Successfully merging this pull request may close these issues.

Starting with 4.23.1 liquibase fails to aquire lock on derby database in Pax Exam integration test
3 participants
@filipelautert @rberezen @MalloD12