Don't execute CustomSqlChanges to generate logs #5524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested locally and with the package build on this pr against my example provided in the issue <dependency>
<groupId>org.liquibase</groupId>
<artifactId>liquibase-core</artifactId>
<version>5523-customsqlchange-execute-method-runs-twice-SNAPSHOT</version>
</dependency> |
2 tasks
filipelautert
approved these changes
Jan 29, 2024
suryaaki2
approved these changes
Jan 29, 2024
rberezen
approved these changes
Jan 29, 2024
Alf-Melmac
deleted the
5523-customsqlchange-execute-method-runs-twice
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
CustomSQLChanges were being executed twice: one to generate logs and the other one was the actual run.
This PR prevents log generation execution.
This fixes #5523