Handle stored logic with parameters in the dependency graph DAT-15747 #5581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| String name = schemaName + "." + obj.getName(); | ||
| if (dependencyOrder.contains(name)) { | ||
| String objectName = obj.getName(); | ||
| String name = schemaName + "." + objectName; |
There was a problem hiding this comment.
Nice, now we can have the same object in different schemas.
filipelautert
approved these changes
Feb 8, 2024
wwillard7800
temporarily deployed
to
internal
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
This change handles procedures and functions which have parameters. The name of these objects that comes back from the dependency query does not include the actual parameter names, just the types. This makes the dependency sorting ignore these objects and just put them at the bottom of the list, instead of in their correct place.
Things to be aware of
Things to worry about
Additional Context