Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring update summary options to all update-related goals of the maven plugin #5592

Conversation

KeepItSimpleStupid
Copy link
Contributor

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

#4395 and #5077 brought the options showSummary and showSummaryOutput to the update goal of the maven plugin.

These options seem to be relevant for the updateSQL and updateTestingRollback goals as well, so this PR brings them to the parent abstract class of all these goals

Things to be aware of

Things to worry about

Additional Context

… plugin

 liquibase#4395 and liquibase#5077 brought the options `showSummary` and `showSummaryOutput` to the `update` goal of the maven plugin.

These options seem to be relevant for the `updateSQL` and `updateTestingRollback` goals as well, so this PR brings them to the parent abstract class of all these goals
Copy link
Contributor

@MalloD12 MalloD12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Code change looks good to me. This is not applicable for updateSQL, but it is for update and upateTestingRollback. I manually tested the change with these last two commands and worked correctly.

Thanks for the PR,
Daniel.

@KeepItSimpleStupid
Copy link
Contributor Author

Thanks @MalloD12, the pleasure is mine : liquibase is a great tool ! :)

Since the showSummary and showSummaryOutput are not applicable for the updateSQL goal, do you want me to rework the PR to acknowledge that ?
i.e. duplicate the declaration & logic of these 2 fields in LiquibaseUpdateTestingRollback instead of moving it to AbstractLiquibaseUpdateMojo ?

@MalloD12
Copy link
Contributor

Thanks @MalloD12, the pleasure is mine : liquibase is a great tool ! :)

Since the showSummary and showSummaryOutput are not applicable for the updateSQL goal, do you want me to rework the PR to acknowledge that ? i.e. duplicate the declaration & logic of these 2 fields in LiquibaseUpdateTestingRollback instead of moving it to AbstractLiquibaseUpdateMojo ?

Hi @KeepItSimpleStupid,

I think that's not needed. Let's leave it as it is. Having it in the AbstractLiquibaseUpdateMojo is ok and that's pretty much how we handle it for CLI having all the showSummary logic in the AbtractUpdateCommandStep class.

Thanks,
Daniel.

@filipelautert filipelautert merged commit dd0ca25 into liquibase:master Mar 4, 2024
31 of 33 checks passed
@filipelautert filipelautert added this to the 1NEXT milestone Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants