Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/delete-package-versions from 3 to 5 #5641

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 29, 2024

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [actions/delete-package-versions](https://github.com/actions/delete-package-versions) from 3 to 5.
- [Release notes](https://github.com/actions/delete-package-versions/releases)
- [Commits](actions/delete-package-versions@v3...v5)

---
updated-dependencies:
- dependency-name: actions/delete-package-versions
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@filipelautert
Copy link
Collaborator

@sayaliM0412 could you review this PR?

@sayaliM0412
Copy link
Contributor

sayaliM0412 commented Feb 29, 2024

@sayaliM0412 could you review this PR?

it will break as package-type: is mandatory which might break our workflow. It was introduced in @v4 :https://github.com/actions/delete-package-versions/releases/tag/v4.0.0

@filipelautert
Copy link
Collaborator

it will break as package-type: is mandatory which might break our workflow. It was introduced in @v4 :https://github.com/actions/delete-package-versions/releases/tag/v4.0.0

Thanks, I added package-type: maven . I hope this is fine now.

@sayaliM0412
Copy link
Contributor

@sayaliM0412 could you review this PR?

it will break as package-type: is mandatory which might break our workflow. It was introduced in @v4 :https://github.com/actions/delete-package-versions/releases/tag/v4.0.0

I think this can be merged @filipelautert and we need to "reopen" liquibase-pro PR as well as it is failing and update the package-type: maven in that as well .
eg: https://github.com/liquibase/liquibase-pro/pull/1551.

@filipelautert filipelautert merged commit f6bfa4b into master Mar 4, 2024
33 of 34 checks passed
@filipelautert filipelautert deleted the dependabot/github_actions/actions/delete-package-versions-5 branch March 4, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file sdou Security, Driver and other updates
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants