Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java Command scope issues #5669

Open
1 of 2 tasks
symekutz opened this issue Mar 7, 2024 · 0 comments
Open
1 of 2 tasks

Java Command scope issues #5669

symekutz opened this issue Mar 7, 2024 · 0 comments

Comments

@symekutz
Copy link

symekutz commented Mar 7, 2024

Search first

  • I searched and no similar issues were found

Description

The commandScope for history and diff-changelog are not correct.

History - does not have the HIDDEN DATABASE field, this means you have to pass in user, pass and url even when I already have a connection
diff-changelog - The REFERENCE-URL field is still required but user and pass are not. REFERENCE-URL should not be required to diff against a changelog.

Steps To Reproduce

CommandFactory _factory = Scope.getCurrentScope().getSingleton(CommandFactory.class);
CommandDefinition _lbCommandmandDef = _factory.getCommandDefinition(StringUtil.toCamelCase(_sqlclCommand.getType().getName()));
CommandScope _lbCommand = new CommandScope(_lbCommandmandDef.getName());

Review the CommandDefinition

Expected/Desired Behavior

History should take the HIDDEN Database field like the rest of the commands
diff-changelog should not require the REFERENCE-URL

Liquibase Version

4.26.0

Database Vendor & Version

Oracle all

Liquibase Integration

java integration using the commandScope Api's

Liquibase Extensions

No response

OS and/or Infrastructure Type/Provider

all

Additional Context

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR (Thank you!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants