feat: add commons-lang3 as a required dependency for core #5709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
PR https://github.com/liquibase/liquibase/pull/5670/files that was just merged depends on commons-lang3. By verifying our zip & installer we can see that this library is shipped, as it is a dependency for Opencsv library.
This library is also used in another place of the code but in an outlier case.
So to prevent class not found issues it is being declared as a required dependency, otherwise it may brake cases where liquibase is used as a library such as Spring or Hibernate as now it will be called in every execution as per the changes on #5670.
Also adding this as a dependency allows to in remove a lot of code that is available in the library and we have been duplicating inside liquibase code.