Duplicated dependency commons-text - liquibase-core

[marwin1991]

Search first

• I searched and no similar issues were found

Description

Hello, I think commons-text dependecy is duplicated, its included in liquibase core and in com.opencsv:opencsv

Good thing that its the same version, but in the future it can cause Jar hell.

Steps To Reproduce

mvn dependency:tree

Expected/Desired Behavior

no duplicated deps

Liquibase Version

4.27.0

Database Vendor & Version

No response

Liquibase Integration

No response

Liquibase Extensions

No response

OS and/or Infrastructure Type/Provider

No response

Additional Context

No response

Are you willing to submit a PR?

• I'm willing to submit a PR (Thank you!)

[MalloD12]

Hi @marwin1991,

If you see it duplicated yes I agree we should get rid off one of them. I can see org.apache.commons:commons-text is included by com.opencsv:

I don't see commons-text as a sole dependency of core. If you don't mind could you please share where are you seeing both duplicates?

Thanks,
Daniel.

[marwin1991]

@MalloD12
sorry for westing your time, I don't know why i thouth it is

i've tested it with:

mvn
      --batch-mode
      validate
      org.apache.maven.plugins:maven-enforcer-plugin:3.4.1:enforce
      -Denforcer.rules=banDuplicatePomDependencyVersions,dependencyConvergence

and it looks okay.

output of mvn dependecy:tree for me looks a bit diffrent:

And it looks like here core contains commons-text and opencsv

[MalloD12]

Hi @marwin1991,

I can see now what you mean. I've been talking with one other member of the team and he pointed me out to the generated pom file and I can see what you were pointing out there.

Maybe we should add common-text as a core dependency to avoid this being included as an inherited dependency, same with commons-collections4. Do you have any other proposal to fix this?

Thanks,
Daniel.