Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Additional Duplicate File Modes (DEBUG and / or IGNORE) to ResourceAccessor #5856

Open
2 tasks done
k4pran opened this issue Apr 28, 2024 · 1 comment
Open
2 tasks done

Comments

@k4pran
Copy link

k4pran commented Apr 28, 2024

Search first

  • I searched and no similar issues were found

Description

Handling of multiple resources found for a given path is currently limited to two modes - ERROR and WARN. This can be restrictive where more nuanced handling might be necessary, such as in our case where we use custom ResourceAccessors and ClassLoaders. Our scenario involves custom handling for duplicate changelogs that bypasses the seachPath, but we still need to use the ResourceAccessor methods that currently trigger warnings, flooding our logs. Introducing additional modes to adjust the log level could provide better flexibility.

Steps To Reproduce

Set liquibase.duplicateFileMode to GlobalConfiguration.DuplicateFileMode.WARN, will result in warning logs.

Expected/Desired Behavior

No concerns about this current behaviour, however adding additional modes would allow for greater flexibility.

Liquibase Version

4.27.0

Database Vendor & Version

mysql 8.0.34

Liquibase Integration

maven

Liquibase Extensions

No response

OS and/or Infrastructure Type/Provider

Windows

Additional Context

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR (Thank you!)
@MalloD12
Copy link
Contributor

Hi @k4pran,

Thank you for raising this improvement issue. We invite you to submit a PR with your proposed changes, I think that would be ok while extending the current implementation. Please let us know if you have any questions about it.

Thanks,
Daniel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Planned
Development

No branches or pull requests

3 participants