Output changeset execution to UI like rollback does #1932

sergeevik · 2021-06-24T05:18:02Z

Environment

Liquibase Version: 4.4.0

Liquibase Integration & Version: CLI

Pull Request Type

Bug fix (non-breaking change which fixes an issue.)

Description

When use rollback command cli, i see in terminal this log:

Rollback to version R1.0
Liquibase Community 3.10.1 by Datical
Rolling Back Changeset:R1.0...
Rolling Back Changeset:R1.0...
Rolling Back Changeset:R1.0...
Rolling Back Changeset:R1.0...
Rolling Back Changeset:R1.0...
Liquibase: Rollback has been successful.

But when use update, i see only:

Liquibase Community 3.10.1 by Datical
Liquibase: Update has been successful.

PS.. use 4.4.0 version have same result:

Rollback to version R1.0
Liquibase Community 4.4.0 by Datical
####################################################
##   _     _             _ _                      ##
##  | |   (_)           (_) |                     ##
##  | |    _  __ _ _   _ _| |__   __ _ ___  ___   ##
##  | |   | |/ _` | | | | | '_ \ / _` / __|/ _ \  ##
##  | |___| | (_| | |_| | | |_) | (_| \__ \  __/  ##
##  \_____/_|\__, |\__,_|_|_.__/ \__,_|___/\___|  ##
##              | |                               ##
##              |_|                               ##
##                                                ##
##  Get documentation at docs.liquibase.com       ##
##  Get certified courses at learn.liquibase.com  ##
##  Free schema change activity reports at        ##
##      https://hub.liquibase.com                 ##
##                                                ##
####################################################
Starting Liquibase at 19:47:49 (version 4.4.0 #11 built at 2021-06-09 16:36+0000)
Skipping auto-registration
Rolling Back Changeset:R1.0/...
Rolling Back Changeset:R1.0/...
Rolling Back Changeset:R1.0/...
Rolling Back Changeset:R1.0/...
Rolling Back Changeset:R1.0/...
Rolling Back Changeset:R1.0/...
Liquibase: Rollback has been successful.


Liquibase Community 4.4.0 by Datical
####################################################
##   _     _             _ _                      ##
##  | |   (_)           (_) |                     ##
##  | |    _  __ _ _   _ _| |__   __ _ ___  ___   ##
##  | |   | |/ _` | | | | | '_ \ / _` / __|/ _ \  ##
##  | |___| | (_| | |_| | | |_) | (_| \__ \  __/  ##
##  \_____/_|\__, |\__,_|_|_.__/ \__,_|___/\___|  ##
##              | |                               ##
##              |_|                               ##
##                                                ##
##  Get documentation at docs.liquibase.com       ##
##  Get certified courses at learn.liquibase.com  ##
##  Free schema change activity reports at        ##
##      https://hub.liquibase.com                 ##
##                                                ##
####################################################
Starting Liquibase at 19:47:54 (version 4.4.0 #11 built at 2021-06-09 16:36+0000)
Skipping auto-registration
Liquibase: Update has been successful.In pr, i copy logic from ```liquibase.changelog.visitor.RollbackVisitor``` to ```liquibase.changelog.visitor.UpdateVisitor``` wich log info to ui.

With this change. log looks like:

Rollback to version R1.0
####################################################
##   _     _             _ _                      ##
##  | |   (_)           (_) |                     ##
##  | |    _  __ _ _   _ _| |__   __ _ ___  ___   ##
##  | |   | |/ _` | | | | | '_ \ / _` / __|/ _ \  ##
##  | |___| | (_| | |_| | | |_) | (_| \__ \  __/  ##
##  \_____/_|\__, |\__,_|_|_.__/ \__,_|___/\___|  ##
##              | |                               ##
##              |_|                               ##
##                                                ##
##  Get documentation at docs.liquibase.com       ##
##  Get certified courses at learn.liquibase.com  ##
##  Free schema change activity reports at        ##
##      https://hub.liquibase.com                 ##
##                                                ##
####################################################
Starting Liquibase at 20:27:22 (version 4.4.0-local-SNAPSHOT #0 built at 2021-06-24 17:24+0000)
Skipping auto-registration
Rolling Back Changeset:R1.0/...
Rolling Back Changeset:R1.0/...
Liquibase: Rollback has been successful.    ####################################################
##   _     _             _ _                      ##
##  | |   (_)           (_) |                     ##
##  | |    _  __ _ _   _ _| |__   __ _ ___  ___   ##
##  | |   | |/ _` | | | | | '_ \ / _` / __|/ _ \  ##
##  | |___| | (_| | |_| | | |_) | (_| \__ \  __/  ##
##  \_____/_|\__, |\__,_|_|_.__/ \__,_|___/\___|  ##
##              | |                               ##
##              |_|                               ##
##                                                ##
##  Get documentation at docs.liquibase.com       ##
##  Get certified courses at learn.liquibase.com  ##
##  Free schema change activity reports at        ##
##      https://hub.liquibase.com                 ##
##                                                ##
####################################################
Starting Liquibase at 20:27:27 (version 4.4.0-local-SNAPSHOT #0 built at 2021-06-24 17:24+0000)
Skipping auto-registration
Running Changeset:R1.0/...
Running Changeset:R1.0/...
Liquibase: Update has been successful.That may help to see progress in terminal. Without log, user may think that update hung

Fast Track PR Acceptance Checklist:

Build is successful and all new and existing tests pass

Dev Handoff Notes (Internal Use)

Links

Fixed Issue: Stand alone PR
Test Results: https://github.com/liquibase/liquibase/pull/1932/checks

Testing

Steps to Reproduce: See above
Guidance:
- Impact: Calls through our UI service, so doesn't impact outputfile or logging

Dev Verification

Ran new code to see additional messages on update

…base into sergeevik-update_log_to_ui

nvoxland · 2021-12-22T22:15:21Z

Thanks for the PR!

I added a missing space after the : on both the existing rollback and the new update message and updated the branch with the current master code.

php-coder · 2022-01-22T08:10:15Z

liquibase-core/src/main/java/liquibase/changelog/visitor/UpdateVisitor.java

@@ -40,8 +43,12 @@ public Direction getDirection() {
    @Override
    public void visit(ChangeSet changeSet, DatabaseChangeLog databaseChangeLog, Database database,
                      Set<ChangeSetFilterResult> filterResults) throws LiquibaseException {
+        Executor executor = Scope.getCurrentScope().getSingleton(ExecutorService.class).getExecutor("jdbc", database);
+        if (! (executor instanceof LoggingExecutor)) {
+            Scope.getCurrentScope().getUI().sendMessage("Running Changeset: " + changeSet);


Is this logs directly to stdout or it should respect logging levels? On what level it logs then? I have logging.level.liquibase: WARN (in Spring Boot's application.properties) and after update I see all these messages in console as-is, without date/level/class/etc. For example:

2022-01-22 15:02:34.380 [user: ] INFO 18949 --- [ main] com.zaxxer.hikari.HikariDataSource : HikariPool-1 - Start completed. Running Changeset: liquibase/initial-state.xml::create-users_activation-table::php-coder Running Changeset: liquibase/initial-state.xml::create-users_table::php-coder Running Changeset: liquibase/initial-state.xml::create-countries-table::php-coder ...

It might be related to my dated Spring Boot version, so I'm not fully sure whether it's a bug in Liquibase..

Additional observation: these messages appears also when I run unit tests that use H2 :-/

Agree on this one. We have a few hundreds of change logs and thousands of tests. Imagine how messy build logs are now.

made the logging of visitors(update/rollback) the same

26f9eac

molivasdat added this to To Do in Conditioning++ via automation Nov 23, 2021

molivasdat added BBroad Broad Issue DBAll ImpactMedium IntegrationAny Severity4 TypeEnhancement labels Nov 23, 2021

nvoxland added 2 commits December 22, 2021 16:08

Merge branch 'update_log_to_ui' of https://github.com/sergeevik/liqui…

ecf7f47

…base into sergeevik-update_log_to_ui

Added space to update/rollback messages after ":"

09c8ec6

nvoxland changed the base branch from master to 1_9 December 22, 2021 22:12

nvoxland changed the base branch from 1_9 to master December 22, 2021 22:12

nvoxland changed the title ~~made the logging of visitors(update/rollback) the same~~ Output changeset execution to UI like rollback does Dec 22, 2021

nvoxland approved these changes Dec 22, 2021

View reviewed changes

nvoxland requested a review from suryaaki2 December 22, 2021 22:18

nvoxland moved this from To Do to Code Review in Conditioning++ Dec 22, 2021

suryaaki2 approved these changes Dec 28, 2021

View reviewed changes

suryaaki2 added the SyncTicket label Dec 28, 2021

suryaaki2 moved this from Code Review to Ready for Handoff (In JIRA) in Conditioning++ Dec 28, 2021

suryaaki2 merged commit f7571ab into liquibase:master Jan 18, 2022

Conditioning++ automation moved this from Ready for Handoff (In JIRA) to Done Jan 18, 2022

sergeevik deleted the update_log_to_ui branch January 19, 2022 00:57

nvoxland removed this from Done in Conditioning++ Jan 21, 2022

nvoxland added this to the v4.7.1 milestone Jan 21, 2022

php-coder reviewed Jan 22, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Output changeset execution to UI like rollback does #1932

Output changeset execution to UI like rollback does #1932

sergeevik commented Jun 24, 2021 •

edited by nvoxland

nvoxland commented Dec 22, 2021

php-coder Jan 22, 2022

php-coder Jan 22, 2022 •

edited

php-coder Jan 22, 2022

baev Jan 24, 2022

baev Jan 24, 2022

Output changeset execution to UI like rollback does #1932

Output changeset execution to UI like rollback does #1932

Conversation

sergeevik commented Jun 24, 2021 • edited by nvoxland

Environment

Pull Request Type

Description

Fast Track PR Acceptance Checklist:

Dev Handoff Notes (Internal Use)

Links

Testing

Dev Verification

nvoxland commented Dec 22, 2021

php-coder Jan 22, 2022

Choose a reason for hiding this comment

php-coder Jan 22, 2022 • edited

Choose a reason for hiding this comment

php-coder Jan 22, 2022

Choose a reason for hiding this comment

baev Jan 24, 2022

Choose a reason for hiding this comment

baev Jan 24, 2022

Choose a reason for hiding this comment

sergeevik commented Jun 24, 2021 •

edited by nvoxland

php-coder Jan 22, 2022 •

edited