Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark liquibase-maven-plugin logging configuration as deprecated #2261

Merged
merged 2 commits into from Jan 10, 2022

Conversation

nvoxland
Copy link
Contributor

@nvoxland nvoxland commented Dec 9, 2021

Description

In 4.0, we started ignoring the liquibase-maven-plugin configuration tag in favor of relying on the built-in maven logging system.

That means that liquibase now respects the -q, -X and -e flags and/or the ${maven.home}/conf/logging/simplelogger.properties file file.

But, we just silently ignored the configuration users had.

This PR outputs an ERROR level log if the configuration is set letting users know it is being ignored.

New behavior

  • If there is no configuration, there is no message
  • If you have a configuration in your maven project, log a {{ The liquibase-maven-plugin now manages logging via the standard maven logging config, not the 'logging' configuration. Use the -q, -X and -e flags or configure Maven logging properties file following these instructions: https://maven.apache.org/mavenlogging.html}} ERRORlevel message

Dev Handoff Notes (Internal Use)

Links

Testing

  • Steps to Reproduce: See above
  • Guidance:
    • Impact: any liquibase-maven-plugin commands

Dev Verification

Verified message when and only when the logging configuration is set.

Test Requirements (Liquibase Internal QA)

Manual Tests

Verify that log message is displayed when with global configuration.

  • specify <liquibase.logging>debug</liquibase.logging> in your pom.xml file under properties section
  • execute any liquibase command
  • ERROR level log message is displayed

Verify that log message is displayed when with liquibasemavenplagin configuration.

  • remove global logging configuration in pom.xml file
  • specify logging configuration in pom.xml file under liquibase-maven-plagin section
<plugin>
		<groupId>org.liquibase</groupId>
		<artifactId>liquibase-maven-plugin</artifactId>
		<version>0-SNAPSHOT</version>
		<configuration>
			<logging>debug</logging>
		</configuration>
</plugin>
  • execute any liquibase command
  • ERROR level log message is displayed

Verify that message is not displayed when configuration is not specified.

  • make sure that there is no configuration specified in pom.xml file
  • execute any liquibase command
  • no message is displayed

Automated Tests

No new functional tests required for this fix.

┆Issue is synchronized with this Jira Bug by Unito
┆fixVersions: Community 4.x

@nvoxland nvoxland added this to To Do in Conditioning++ via automation Dec 9, 2021
@nvoxland nvoxland moved this from To Do to Code Review in Conditioning++ Dec 9, 2021
@suryaaki2 suryaaki2 moved this from Code Review to Ready for Handoff (In JIRA) in Conditioning++ Dec 13, 2021
@nvoxland nvoxland merged commit 3531b51 into master Jan 10, 2022
Conditioning++ automation moved this from Ready for Handoff (In JIRA) to Done Jan 10, 2022
@nvoxland nvoxland deleted the mark-maven-logging-deprecated branch January 10, 2022 23:02
@nvoxland nvoxland removed this from Done in Conditioning++ Jan 21, 2022
@nvoxland nvoxland added this to the v4.7.1 milestone Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants