point users to init project command if they forget a supported argument in any command (DAT-8641) #2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvoxland
suggested changes
Jan 11, 2022
liquibase-core/src/main/java/liquibase/command/CommandArgumentDefinition.java
Outdated
Show resolved
Hide resolved
liquibase-core/src/main/java/liquibase/command/CommandArgumentNames.java
Outdated
Show resolved
Hide resolved
liquibase-core/src/main/java/liquibase/exception/CommandValidationException.java
Outdated
Show resolved
Hide resolved
nvoxland
approved these changes
Jan 11, 2022
suryaaki2
approved these changes
Jan 12, 2022
| .description("The root changelog file").build(); | ||
| URL_ARG = builder.argument("url", String.class).required() | ||
| URL_ARG = builder.argument(CommonArgumentNames.URL, String.class).required() | ||
| .description("The JDBC database connection URL").build(); | ||
| DEFAULT_SCHEMA_NAME_ARG = builder.argument("defaultSchemaName", String.class) |
There was a problem hiding this comment.
While they aren't as commonly used, defaultSchemaName and driverPropertiesFile are part of the set of common arguments across commands.
There was a problem hiding this comment.
I was contemplating changing around the other arguments as well. I'll do that in another PR to keep things nice and separate.
wwillard7800
approved these changes
Jan 12, 2022
nvoxland
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a heavy-handed approach to this, and it does not have to be.
There are two commits:
First, the actual change. This is to adjust the message thrown by the exception during the validation stage of each argument.
Second, refactoring all existing commands which use any of the supported arguments to all use common code for the initialization of the argument. I did this primarily because I was concerned that the equality check would fail if one developer instantiated a command argument in a slightly different way (
changelogfilevschangelogFile, for example)