Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DAT-8906] Added validation errors for SQLite and DB2z databases #2359

Merged
merged 1 commit into from Jan 19, 2022

Conversation

AlexanderSashchenko
Copy link
Contributor

Environment

Liquibase Version: 4.6.2

Liquibase Integration & Version: CLI

Liquibase Extension(s) & Version: na

Database Vendor & Version: db2z 11, sqlite 3.34.0

Operating System Type & Version: windows 10

Pull Request Type

  • Bug fix (non-breaking change which fixes an issue.)
  • Enhancement/New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Some Liquibase community change types didn't throw validation errors previously ('not supported' exception) though Liquibase doesn't support them according to documentation. The list of databases and changetypes for which validation errors were added:
SQLite (createProcedure, dropProcedure, renameSequence);
DB2z (modifyDataType, addAutoIncrement)

Steps To Reproduce

Run update command against upper named databases/change types;

Actual Behavior

Different SQL syntax errors are thrown (liquibase tries to generate and execute queries that cause syntax errors)

Expected/Desired Behavior

Validation error (e.g. createProcedure is not allowed for SQLite) should be thrown.

Fast Track PR Acceptance Checklist:

Need Help?

Come chat with us on our discord channel

@AlexanderSashchenko AlexanderSashchenko changed the title added validation errors for SQLite and DB2z databases [DAT-8906] Added validation errors for SQLite and DB2z databases Jan 12, 2022
@nvoxland nvoxland merged commit 22963c0 into master Jan 19, 2022
@nvoxland nvoxland deleted the DAT-8906 branch January 19, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants