Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MaxDB for sequences #932

Merged
merged 5 commits into from Jan 12, 2022
Merged

Support MaxDB for sequences #932

merged 5 commits into from Jan 12, 2022

Conversation

wuttke
Copy link
Contributor

@wuttke wuttke commented Nov 9, 2019

MaxDB Liquibase Diff does not work for sequences as this database (liquibase-maxdb repo) is not included in the SequenceSnapshotGenerator.
(Query should be moved to the Database successor, anyways...)
(I also backported this to the 3.5.x branch.)

┆Issue is synchronized with this Jira Bug by Unito
┆fixVersions: Community 4.x

@wuttke
Copy link
Contributor Author

wuttke commented Nov 9, 2019

There is also problems here:

  • JdbcDatabaseSnapshot
  • UniqueConstraintSnapshotGenerator

@wuttke
Copy link
Contributor Author

wuttke commented Dec 12, 2019

Could this PR be merged?

@nvoxland
Copy link
Contributor

Thanks! We're catching up on a set of fixes already in master, then will get this merged in.

@nvoxland nvoxland self-requested a review December 27, 2019 22:22
@SteveDonie SteveDonie added TypeBug and removed bugfix labels Mar 3, 2020
@datical-jenkins datical-jenkins changed the title Support MaxDB for sequences LB-41 ⁃ Support MaxDB for sequences Mar 4, 2020
@datical-jenkins datical-jenkins changed the title LB-41 ⁃ Support MaxDB for sequences Support MaxDB for sequences Mar 5, 2020
@ro-rah ro-rah added RiskLow Trivial changes in spelling, documentation changes, focused bug fixes, etc. Sprint7.5 and removed StatusDiscovery labels Apr 27, 2020
@ro-rah
Copy link

ro-rah commented Apr 27, 2020

Placing Risk Low flag, I can see @nvoxland has approved these changes.

@kataggart kataggart added this to To Do in Conditioning++ via automation Dec 20, 2021
…tke-master

# Conflicts:
#	liquibase-core/src/main/java/liquibase/snapshot/jvm/UniqueConstraintSnapshotGenerator.java
@nvoxland nvoxland moved this from To Do to Code Review in Conditioning++ Jan 5, 2022
@suryaaki2 suryaaki2 moved this from Code Review to Ready for Handoff (In JIRA) in Conditioning++ Jan 6, 2022
@liquibase liquibase deleted a comment from sync-by-unito bot Jan 11, 2022
@liquibase liquibase deleted a comment from sync-by-unito bot Jan 11, 2022
@nvoxland nvoxland changed the base branch from master to 1_9 January 12, 2022 14:55
@nvoxland nvoxland changed the base branch from 1_9 to master January 12, 2022 14:55
@nvoxland nvoxland merged commit cabacb1 into liquibase:master Jan 12, 2022
Conditioning++ automation moved this from Ready for Handoff (In JIRA) to Done Jan 12, 2022
@nvoxland nvoxland removed this from Done in Conditioning++ Jan 21, 2022
@nvoxland nvoxland added this to the v4.7.1 milestone Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DBMaxDB ImpactLow IntegrationAny RiskLow Trivial changes in spelling, documentation changes, focused bug fixes, etc. SyncTicket ThemeDBObjects TypeBug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants