Support for Lian-Li Uni #636
Draft
+131
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liquidctl/driver/lianli_uni.py
Outdated
| self._set_rgb_sync() | ||
|
|
||
| def set_fixed_speed(self, channel, duty, **kwargs): | ||
| if channel not in range(1, 7): |
There was a problem hiding this comment.
channel here is fan1, fan2 etc. from the command, in lowercase. You need to parse the actual channel number.
There was a problem hiding this comment.
Good catch, I just made a change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what the changes are meant to address.
If the implementation is not trivial, please also include a short overview.
Fixes: #629
Closes: #629
Related: n/a
Checklist:
docs/*guide.mddevice guides, with "new/changed in" notesliquidctl.8Linux/Unix/Mac OS man pagedocs/developer/protocolNew CLI flag?
extra/completions/New device?
extra/linux/71-liquidctl.rules(instructions in the file header)e) andgitMRLVNew driver?
docs/developer/protocol/