Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ssr-client] Move experimental hydrate modules to @lit-labs/ssr-client #3713

Closed
1 task done
augustjk opened this issue Mar 8, 2023 · 1 comment · Fixed by #3720
Closed
1 task done

[ssr-client] Move experimental hydrate modules to @lit-labs/ssr-client #3713

augustjk opened this issue Mar 8, 2023 · 1 comment · Fixed by #3720
Assignees

Comments

@augustjk
Copy link
Member

augustjk commented Mar 8, 2023

Should this be an RFC?

  • This is not a substantial change

Which package is this a feature request for?

SSR (@lit-labs/ssr)

Description

lit-html/experimental-hydrate.js and lit-element/experimental-hydrate-support.js should be moved to @lit-labs/ssr-client so that changes that affect only SSR & hydration concerns don't need to bump versions of the core lit-html and lit-element packages, especially when those could be considered breaking.

Recent examples:
#3667
#3677

When the modules are moved to @lit-labs/client, I'm thinking "experimental" can be dropped by virtue of it being in the @lit-labs namespace. Maybe..
lit-html/experimental-hydrate.js -> @lit-labs/ssr-client/hydrate-lit-html.js
lit-element/experimental-hydrate-support.js -> @lit-labs/ssr-client/lit-element-hydrate-support.js

lit-html/experimental-hydrate.js has code that depends on having a Node build so that will need to be added for @lit-labs/ssr-client.

We can keep the entrypoints in lit-html and lit-element (re-exported from lit) but mark as deprecated, to eventually remove. Update all docs to point to their new location instead.

Alternatives and Workarounds

N/A

@augustjk augustjk self-assigned this Mar 8, 2023
@augustjk
Copy link
Member Author

augustjk commented Mar 9, 2023

Type checking fails when trying to pull out lit-html/experimental-hydrate.js outside of lit-html due to /** @internal */ marked properties/methods.

from TemplateInstance:

  • _parts
  • _$endNode
  • _$template

from ChildPart:

  • _$getTemplate()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant