Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[labs/ssr] Consider other DOM shims for ARIA attr reflection during SSR #3741

Open
1 task done
augustjk opened this issue Mar 21, 2023 · 0 comments
Open
1 task done

Comments

@augustjk
Copy link
Member

Should this be an RFC?

  • This is not a substantial change

Which package is this a feature request for?

SSR (@lit-labs/ssr)

Description

Context: #3677 (comment)

The ARIA attribute reflection logic in LitElementRenderer is dependent on our implementation of attachInternals() for HTMLElement in @lit-labs/ssr-dom-shim and may not work for users of other DOM shims. Currently jsdom nor happy-dom implement attachInternals() so there's nothing to support but we'll have to address this as ElementInternals gets wider adoption.

Alternatives and Workarounds

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Triaged
Development

No branches or pull requests

1 participant