Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[labs/ssr-client] Don't depend on shim module for internals attr prefix #3769

Open
1 task done
augustjk opened this issue Mar 28, 2023 · 0 comments
Open
1 task done

[labs/ssr-client] Don't depend on shim module for internals attr prefix #3769

augustjk opened this issue Mar 28, 2023 · 0 comments

Comments

@augustjk
Copy link
Member

Should this be an RFC?

  • This is not a substantial change

Which package is this a feature request for?

Other/unknown (please mention in description)

Description

Context: #3720 (comment)

Remove dependence on import {HYDRATE_INTERNALS_ATTR_PREFIX} from '@lit-labs/ssr-dom-shim'; and just declare it in module.

We can do the same where it's used for ssr-dom-shim.

Alternatives and Workarounds

.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Lit Project Board
Status: 📋 Triaged
Milestone
No milestone
Development

No branches or pull requests
1 participant
@augustjk