Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[labs/virtualizer] Document grid layout #4505

Open
1 task done
graynorton opened this issue Jan 18, 2024 · 1 comment · May be fixed by #4543
Open
1 task done

[labs/virtualizer] Document grid layout #4505

graynorton opened this issue Jan 18, 2024 · 1 comment · May be fixed by #4543
Labels
Good First Issue

Comments

@graynorton
Copy link
Contributor

Should this be an RFC?

  • This is not a substantial change

Which package is this a feature request for?

Virtualizer (@lit-labs/virtualizer)

Description

Virtualizer's grid layout is not currently documented; it should be.

This Playground contains most of the relevant info: https://lit.dev/playground/#gist=a5960ffd0cb67c61083b4df0f9372eeb

The relevant source is mostly in these files:

https://github.com/lit/lit/blob/main/packages/labs/virtualizer/src/layouts/shared/SizeGapPaddingBaseLayout.ts

https://github.com/lit/lit/blob/main/packages/labs/virtualizer/src/layouts/shared/GridBaseLayout.ts

Alternatives and Workarounds

N/A
@JamesIves
Copy link

I'd be happy to take a stab at this!

@JamesIves JamesIves linked a pull request Feb 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue
Projects
Lit Project Board
Status: 📋 Triaged
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[lit-virtualizer] Fixes #4505 - Adds documentation for lit-virtualizer/grid JamesIves/lit
2 participants
@graynorton @JamesIves