Change window to globalThis in Virtualizer.ts for SSR #4564

IMinchev64 · 2024-02-27T08:44:41Z

changeset-bot · 2024-02-27T08:44:45Z

🦋 Changeset detected

Latest commit: 3c45d20

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@lit-labs/virtualizer	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-cla · 2024-02-27T08:44:45Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

github-actions · 2024-02-27T08:44:55Z

📊 Tachometer Benchmark Results

Summary

⏳ Benchmarks are currently running. Results below are out of date.

nop-update

this-change, tip-of-tree, previous-release: slower ❌ 1% - 10% (0.12ms - 1.03ms)
^{this-change vs tip-of-tree}

render

this-change: 45.47ms - 47.02ms
this-change, tip-of-tree, previous-release: slower ❌ 1% - 8% (0.26ms - 1.39ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +3% (-0.40ms - +0.94ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-0.75ms - +0.33ms)
^{this-change vs tip-of-tree}

update

this-change: 483.17ms - 492.40ms
this-change, tip-of-tree, previous-release: slower ❌ 2% - 15% (0.90ms - 5.66ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +3% (-1.67ms - +1.90ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-7.89ms - +3.03ms)
^{this-change vs tip-of-tree}

update-reflect

this-change: 490.59ms - 499.82ms
this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-5.82ms - +4.47ms)
^{this-change vs tip-of-tree}

Results

⏳ Benchmarks are currently running. Results below are out of date.

this-change

Browser: chrome-headless 122.0.6261.128
Sample size: 50
Built by: Benchmarks #6170
Commit: c225fe4

render

Version	Avg time	vs
	45.47ms - 47.02ms	-

update

Version	Avg time	vs
	483.17ms - 492.40ms	-

update-reflect

Version	Avg time	vs
	490.59ms - 499.82ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 122.0.6261.128
Sample size: 30
Built by: Benchmarks #6170
Commit: c225fe4

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	18.70ms - 19.63ms	-	slower ❌ 1% - 8% 0.26ms - 1.39ms	unsure 🔍 -3% - +4% -0.54ms - +0.76ms
tip-of-tree tip-of-tree	18.03ms - 18.66ms	faster ✔ 1% - 7% 0.26ms - 1.39ms	-	faster ✔ 1% - 7% 0.16ms - 1.26ms
previous-release previous-release	18.60ms - 19.51ms	unsure 🔍 -4% - +3% -0.76ms - +0.54ms	slower ❌ 1% - 7% 0.16ms - 1.26ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	39.90ms - 43.43ms	-	slower ❌ 2% - 15% 0.90ms - 5.66ms	unsure 🔍 -1% - +12% -0.51ms - +4.70ms
tip-of-tree tip-of-tree	36.78ms - 39.99ms	faster ✔ 2% - 13% 0.90ms - 5.66ms	-	unsure 🔍 -9% - +3% -3.69ms - +1.32ms
previous-release previous-release	37.65ms - 41.49ms	unsure 🔍 -11% - +1% -4.70ms - +0.51ms	unsure 🔍 -4% - +10% -1.32ms - +3.69ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	11.14ms - 11.74ms	-	slower ❌ 1% - 10% 0.12ms - 1.03ms	slower ❌ 0% - 10% 0.06ms - 1.04ms
tip-of-tree tip-of-tree	10.52ms - 11.21ms	faster ✔ 1% - 9% 0.12ms - 1.03ms	-	unsure 🔍 -5% - +5% -0.54ms - +0.50ms
previous-release previous-release	10.50ms - 11.27ms	faster ✔ 1% - 9% 0.06ms - 1.04ms	unsure 🔍 -5% - +5% -0.50ms - +0.54ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 122.0.6261.128
Sample size: 50
Built by: Benchmarks #6170
Commit: c225fe4

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	33.08ms - 34.01ms	-	unsure 🔍 -1% - +3% -0.40ms - +0.94ms	unsure 🔍 -2% - +2% -0.67ms - +0.73ms
tip-of-tree tip-of-tree	32.80ms - 33.76ms	unsure 🔍 -3% - +1% -0.94ms - +0.40ms	-	unsure 🔍 -3% - +1% -0.94ms - +0.47ms
previous-release previous-release	33.00ms - 34.04ms	unsure 🔍 -2% - +2% -0.73ms - +0.67ms	unsure 🔍 -1% - +3% -0.47ms - +0.94ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	68.00ms - 70.14ms	-	unsure 🔍 -2% - +3% -1.67ms - +1.90ms	unsure 🔍 -2% - +3% -1.19ms - +1.91ms
tip-of-tree tip-of-tree	67.53ms - 70.38ms	unsure 🔍 -3% - +2% -1.90ms - +1.67ms	-	unsure 🔍 -2% - +3% -1.57ms - +2.05ms
previous-release previous-release	67.60ms - 69.83ms	unsure 🔍 -3% - +2% -1.91ms - +1.19ms	unsure 🔍 -3% - +2% -2.05ms - +1.57ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 122.0.6261.128
Sample size: 50
Built by: Benchmarks #6170
Commit: c225fe4

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	31.54ms - 32.19ms	-	unsure 🔍 -2% - +1% -0.75ms - +0.33ms	unsure 🔍 -2% - +1% -0.72ms - +0.29ms
tip-of-tree tip-of-tree	31.65ms - 32.51ms	unsure 🔍 -1% - +2% -0.33ms - +0.75ms	-	unsure 🔍 -2% - +2% -0.58ms - +0.57ms
previous-release previous-release	31.70ms - 32.47ms	unsure 🔍 -1% - +2% -0.29ms - +0.72ms	unsure 🔍 -2% - +2% -0.57ms - +0.58ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	514.87ms - 522.33ms	-	unsure 🔍 -2% - +1% -7.89ms - +3.03ms	unsure 🔍 -2% - +1% -8.85ms - +2.87ms
tip-of-tree tip-of-tree	517.04ms - 525.02ms	unsure 🔍 -1% - +2% -3.03ms - +7.89ms	-	unsure 🔍 -1% - +1% -6.59ms - +5.47ms
previous-release previous-release	517.07ms - 526.10ms	unsure 🔍 -1% - +2% -2.87ms - +8.85ms	unsure 🔍 -1% - +1% -5.47ms - +6.59ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	523.51ms - 530.52ms	-	unsure 🔍 -1% - +1% -5.82ms - +4.47ms	unsure 🔍 -1% - +1% -3.99ms - +6.16ms
tip-of-tree tip-of-tree	523.93ms - 531.45ms	unsure 🔍 -1% - +1% -4.47ms - +5.82ms	-	unsure 🔍 -1% - +1% -3.49ms - +7.01ms
previous-release previous-release	522.27ms - 529.59ms	unsure 🔍 -1% - +1% -6.16ms - +3.99ms	unsure 🔍 -1% - +1% -7.01ms - +3.49ms	-

_{tachometer-reporter-action v2 for Benchmarks}

IMinchev64 · 2024-03-12T08:50:02Z

I apologize for being pushy, but will there be any update on this? @kevinpschaaf

justinfagnani · 2024-03-12T15:12:33Z

@IMinchev64 I'm taking a look. Just kicked off the tests.

github-actions · 2024-03-12T15:15:16Z

The size of lit-html.js and lit-core.min.js are as expected.

justinfagnani · 2024-03-12T17:16:49Z

@IMinchev64 this looks good. We just need to format the file and add a changeset file (run npm run changeset).

…v64/lit into iminchev/virtualizer-ssr

IMinchev64 · 2024-03-18T08:14:41Z

@IMinchev64 this looks good. We just need to format the file and add a changeset file (run npm run changeset).

@justinfagnani Is it fine now?

enesozturk · 2024-03-22T13:15:22Z

Hey guts, any update to this? @IMinchev64 @kevinpschaaf. Thinking to use it in our product: #4557 (comment)

Thanks 🙏

justinfagnani · 2024-03-22T19:06:39Z

@enesozturk I'm re-running CI now. Looks like the file may still need to be formatted though. cc @IMinchev64

enesozturk · 2024-03-25T08:03:18Z

Thanks @justinfagnani, I'll be following the updates

…v64/lit into iminchev/virtualizer-ssr

IMinchev64 · 2024-03-25T12:46:48Z

@justinfagnani I finished running the lint and format scripts as per the guidelines so now the formatting should be fine as well

justinfagnani · 2024-03-26T16:55:57Z

@IMinchev64 the formatting looks like it's formatting way too many files. Do you have the latest dependencies? Make sure your branch is synced to make and run npm ci.

enesozturk · 2024-04-01T15:00:08Z

Hey team, any update to this? @IMinchev64 @justinfagnani

IMinchev64 · 2024-04-01T15:06:28Z

I'm currently looking into what went wrong with the formatting. @enesozturk

This reverts commit b82ca10.

This reverts commit 92ef921.

IMinchev64 · 2024-04-01T15:21:24Z

@justinfagnani I hope the formatting is correct now. It's just for the Virtualizer.ts now so fingers crossed all is good.

IMinchev64 · 2024-04-18T10:27:41Z

@justinfagnani Can you rerun the ci please?

enesozturk · 2024-04-19T16:54:29Z

@justinfagnani @IMinchev64 seems CI is good, do you have a plan to release this soon? I'd be the first one try it 🙏

hrmcdonald · 2024-04-23T16:37:45Z

Would love to get this update! This is a blocker for us using this in components right now as well.

augustjk

I don't want to specifically block this from merging as is, but I don't think this specifically makes virtualizer support SSR. It may prevent it from erroring during SSR but I suspect it won't actually render anything in the server. I'm unsure if that might lead to a hydration mismatch client-side.

packages/labs/virtualizer/src/Virtualizer.ts

.changeset/rare-actors-grab.md

Co-authored-by: Augustine Kim <ajk830@gmail.com>

Change window to globalThis in Virtualizer.ts for SSR

4fb20f8

IMinchev64 requested a review from kevinpschaaf as a code owner February 27, 2024 08:44

Merge branch 'main' into iminchev/virtualizer-ssr

fad227e

IMinchev64 and others added 3 commits March 15, 2024 14:10

Add changeset

0a5c10a

Merge branch 'iminchev/virtualizer-ssr' of https://github.com/IMinche…

eaf07f2

…v64/lit into iminchev/virtualizer-ssr

Merge branch 'main' into iminchev/virtualizer-ssr

5858272

IMinchev64 added 3 commits March 25, 2024 14:43

run lint and format

b82ca10

more auto-format changes

92ef921

Merge branch 'iminchev/virtualizer-ssr' of https://github.com/IMinche…

c225fe4

…v64/lit into iminchev/virtualizer-ssr

IMinchev64 and others added 4 commits April 1, 2024 18:06

Merge branch 'main' into iminchev/virtualizer-ssr

cdc3b79

Revert "run lint and format"

db30231

This reverts commit b82ca10.

Revert "more auto-format changes"

452d072

This reverts commit 92ef921.

Format Virtualizer.ts

c83b82d

enesozturk mentioned this pull request Apr 2, 2024

feat(swap): 1inch swaps WalletConnect/web3modal#1491

Closed

Merge branch 'main' into iminchev/virtualizer-ssr

29de69f

enesozturk mentioned this pull request Apr 15, 2024

feat: convert WalletConnect/web3modal#2116

Merged

Merge branch 'main' into iminchev/virtualizer-ssr

2da28cc

augustjk reviewed May 7, 2024

View reviewed changes

packages/labs/virtualizer/src/Virtualizer.ts Outdated Show resolved Hide resolved

.changeset/rare-actors-grab.md Outdated Show resolved Hide resolved

IMinchev64 and others added 3 commits May 8, 2024 11:34

Update packages/labs/virtualizer/src/Virtualizer.ts

37c3699

Co-authored-by: Augustine Kim <ajk830@gmail.com>

Update .changeset/rare-actors-grab.md

435b10e

Co-authored-by: Augustine Kim <ajk830@gmail.com>

Merge branch 'main' into iminchev/virtualizer-ssr

3c45d20

Change window to globalThis in Virtualizer.ts for SSR #4564

Are you sure you want to change the base?

Change window to globalThis in Virtualizer.ts for SSR #4564

Conversation

IMinchev64 commented Feb 27, 2024

changeset-bot bot commented Feb 27, 2024 • edited

🦋 Changeset detected

google-cla bot commented Feb 27, 2024

github-actions bot commented Feb 27, 2024 • edited

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

update-reflect

IMinchev64 commented Mar 12, 2024

justinfagnani commented Mar 12, 2024

github-actions bot commented Mar 12, 2024

justinfagnani commented Mar 12, 2024

IMinchev64 commented Mar 18, 2024

enesozturk commented Mar 22, 2024

justinfagnani commented Mar 22, 2024

enesozturk commented Mar 25, 2024

IMinchev64 commented Mar 25, 2024

justinfagnani commented Mar 26, 2024

enesozturk commented Apr 1, 2024

IMinchev64 commented Apr 1, 2024 • edited

IMinchev64 commented Apr 1, 2024

IMinchev64 commented Apr 18, 2024

enesozturk commented Apr 19, 2024

hrmcdonald commented Apr 23, 2024

augustjk left a comment

Choose a reason for hiding this comment

changeset-bot bot commented Feb 27, 2024 •

edited

github-actions bot commented Feb 27, 2024 •

edited

IMinchev64 commented Apr 1, 2024 •

edited