Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[localize] Fail build on missing translations #4566

Open
1 task done
stevenkuster opened this issue Feb 29, 2024 · 0 comments
Open
1 task done

[localize] Fail build on missing translations #4566

stevenkuster opened this issue Feb 29, 2024 · 0 comments

Comments

@stevenkuster
Copy link

Should this be an RFC?

  • This is not a substantial change

Which package is this a feature request for?

Localize (@lit/localize)

Description

It would be very helpful to be able to have the lit-localize build command fail on missing translations. That way it can be used in CI to determine if code contains missing translations and prevent that from ending up in production code.

And idea would be to add a command line flag to the lit-localize build command so it can be set only during CI.

Alternatives and Workarounds

In theory you could read the output of the build command and see if it contains is missing, using canonical text as fallback. But that means you can't fail early and have to wait for the entire build to succeed first.

@augustjk augustjk changed the title Fail build on missing translations [localize] Fail build on missing translations Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant