Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lit] Add "types" to package exports #3320

Merged
merged 3 commits into from Sep 29, 2022
Merged

[lit] Add "types" to package exports #3320

merged 3 commits into from Sep 29, 2022

Conversation

augustjk
Copy link
Member

Problem

I noticed build failing in pipeline like this https://github.com/lit/lit/actions/runs/3148045621/jobs/5118162175#step:7:67
Module self reference wasn't working during TypeScript build due to missing "types" export condition for the lit package.

Solution

Add "types" field. This needed to point to ./development/... for the module self reference to work during TypeScript build as that is the specified output directory, so this PR also adds development/ directory to the published package, as well as the "development" export condition. This particular package doesn't really need a "development" export condition at the moment but added those for consistency with our other packages and since the package published to npm would now be including those files anyway.

This also has the benefit of allowing TS moduleResolution to be nodenext.

Supersedes #3252

@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2022

🦋 Changeset detected

Latest commit: 238b5b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
lit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2022

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -1% - +1% (-0.33ms - +0.21ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 75.69ms - 80.06ms
  • lit-html-kitchen-sink: unsure 🔍 -2% - +0% (-0.49ms - +0.03ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -6% - +3% (-0.65ms - +0.32ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: faster ✔ 0% - 3% (0.04ms - 1.89ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -2% - +2% (-0.96ms - +1.08ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 811.84ms - 825.71ms
  • lit-html-kitchen-sink: unsure 🔍 -3% - +2% (-2.45ms - +2.05ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -1% - +1% (-3.97ms - +2.28ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +1% (-1.76ms - +1.53ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +0% (-9.11ms - +3.62ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 811.01ms - 818.37ms
  • reactive-element-list: unsure 🔍 -1% - +2% (-7.32ms - +22.98ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
75.69ms - 80.06ms-

update

VersionAvg timevs
811.84ms - 825.71ms-

update-reflect

VersionAvg timevs
811.01ms - 818.37ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
28.52ms - 28.82ms-unsure 🔍
-2% - +0%
-0.49ms - +0.03ms
unsure 🔍
-1% - +0%
-0.42ms - +0.05ms
tip-of-tree
tip-of-tree
28.69ms - 29.11msunsure 🔍
-0% - +2%
-0.03ms - +0.49ms
-unsure 🔍
-1% - +1%
-0.24ms - +0.33ms
previous-release
previous-release
28.67ms - 29.04msunsure 🔍
-0% - +1%
-0.05ms - +0.42ms
unsure 🔍
-1% - +1%
-0.33ms - +0.24ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
82.70ms - 85.38ms-unsure 🔍
-3% - +2%
-2.45ms - +2.05ms
unsure 🔍
-4% - +1%
-3.21ms - +1.09ms
tip-of-tree
tip-of-tree
82.43ms - 86.04msunsure 🔍
-2% - +3%
-2.05ms - +2.45ms
-unsure 🔍
-4% - +2%
-3.33ms - +1.60ms
previous-release
previous-release
83.42ms - 86.78msunsure 🔍
-1% - +4%
-1.09ms - +3.21ms
unsure 🔍
-2% - +4%
-1.60ms - +3.33ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
25.13ms - 25.55ms-unsure 🔍
-1% - +1%
-0.33ms - +0.21ms
unsure 🔍
-1% - +2%
-0.15ms - +0.41ms
tip-of-tree
tip-of-tree
25.22ms - 25.57msunsure 🔍
-1% - +1%
-0.21ms - +0.33ms
-unsure 🔍
-0% - +2%
-0.06ms - +0.44ms
previous-release
previous-release
25.02ms - 25.39msunsure 🔍
-2% - +1%
-0.41ms - +0.15ms
unsure 🔍
-2% - +0%
-0.44ms - +0.06ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
10.14ms - 10.46ms-unsure 🔍
-6% - +3%
-0.65ms - +0.32ms
unsure 🔍
-2% - +3%
-0.16ms - +0.31ms
tip-of-tree
tip-of-tree
10.01ms - 10.92msunsure 🔍
-3% - +6%
-0.32ms - +0.65ms
-unsure 🔍
-2% - +7%
-0.25ms - +0.73ms
previous-release
previous-release
10.05ms - 10.41msunsure 🔍
-3% - +2%
-0.31ms - +0.16ms
unsure 🔍
-7% - +2%
-0.73ms - +0.25ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
296.80ms - 301.45ms-unsure 🔍
-1% - +1%
-3.97ms - +2.28ms
unsure 🔍
-1% - +1%
-4.46ms - +1.66ms
tip-of-tree
tip-of-tree
297.89ms - 302.05msunsure 🔍
-1% - +1%
-2.28ms - +3.97ms
-unsure 🔍
-1% - +1%
-3.43ms - +2.32ms
previous-release
previous-release
298.54ms - 302.51msunsure 🔍
-1% - +1%
-1.66ms - +4.46ms
unsure 🔍
-1% - +1%
-2.32ms - +3.43ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
54.25ms - 55.08ms-faster ✔
0% - 3%
0.04ms - 1.89ms
unsure 🔍
-1% - +1%
-0.70ms - +0.65ms
tip-of-tree
tip-of-tree
54.80ms - 56.46msslower ❌
0% - 3%
0.04ms - 1.89ms
-unsure 🔍
-0% - +4%
-0.05ms - +1.92ms
previous-release
previous-release
54.16ms - 55.23msunsure 🔍
-1% - +1%
-0.65ms - +0.70ms
unsure 🔍
-3% - +0%
-1.92ms - +0.05ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
124.47ms - 126.88ms-unsure 🔍
-1% - +1%
-1.76ms - +1.53ms
unsure 🔍
-1% - +1%
-1.85ms - +1.73ms
tip-of-tree
tip-of-tree
124.67ms - 126.92msunsure 🔍
-1% - +1%
-1.53ms - +1.76ms
-unsure 🔍
-1% - +1%
-1.68ms - +1.80ms
previous-release
previous-release
124.41ms - 127.06msunsure 🔍
-1% - +1%
-1.73ms - +1.85ms
unsure 🔍
-1% - +1%
-1.80ms - +1.68ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
55.58ms - 56.82ms-unsure 🔍
-2% - +2%
-0.96ms - +1.08ms
unsure 🔍
-0% - +4%
-0.01ms - +1.94ms
tip-of-tree
tip-of-tree
55.32ms - 56.95msunsure 🔍
-2% - +2%
-1.08ms - +0.96ms
-unsure 🔍
-0% - +4%
-0.21ms - +2.02ms
previous-release
previous-release
54.47ms - 55.99msunsure 🔍
-3% - +0%
-1.94ms - +0.01ms
unsure 🔍
-4% - +0%
-2.02ms - +0.21ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
835.39ms - 845.61ms-unsure 🔍
-1% - +0%
-9.11ms - +3.62ms
unsure 🔍
-1% - +1%
-9.51ms - +4.62ms
tip-of-tree
tip-of-tree
839.45ms - 847.04msunsure 🔍
-0% - +1%
-3.62ms - +9.11ms
-unsure 🔍
-1% - +1%
-5.88ms - +6.48ms
previous-release
previous-release
838.06ms - 847.82msunsure 🔍
-1% - +1%
-4.62ms - +9.51ms
unsure 🔍
-1% - +1%
-6.48ms - +5.88ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
924.42ms - 942.60ms-unsure 🔍
-1% - +2%
-7.32ms - +22.98ms
slower ❌
0% - 4%
3.22ms - 36.02ms
tip-of-tree
tip-of-tree
913.56ms - 937.80msunsure 🔍
-2% - +1%
-22.98ms - +7.32ms
-unsure 🔍
-1% - +3%
-6.46ms - +30.05ms
previous-release
previous-release
900.24ms - 927.54msfaster ✔
0% - 4%
3.22ms - 36.02ms
unsure 🔍
-3% - +1%
-30.05ms - +6.46ms
-

tachometer-reporter-action v2 for Benchmarks

"default": "./polyfill-support.js"
},
"./static-html.js": {
"types": "./development/static-html.d.ts",
"development": "./development/static-html.js",
"default": "./static-html.js"
Copy link
Member

@aomarks aomarks Sep 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need development for lit, because all the differences are in the underlying packages

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it's no different than the default build. The types field does need to point to the ./development/* directory for the self reference to work during build time since that is the specified outDir so I did have to add the entire /development/ directory to the published package. We could possibly just include the d.ts and d.ts.map files there.

I noticed some of the labs packages also include the (unnecessary) "development" export probably just from copy pasting so I opted to just follow that here too.

An alternative, and perhaps arguably more sensible, thing to do might be to change the tsc outDir to emit directly to the package root and not do the treemirror copy for the packages that don't need a development build but that seemed like extra work and I wasn't sure if that would require tweaking the rollup config as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative, and perhaps arguably more sensible, thing to do might be to change the tsc outDir to emit directly to the package root and not do the treemirror copy for the packages that don't need a development build but that seemed like extra work and I wasn't sure if that would require tweaking the rollup config as well.

+1 to that, the minified files in lit only save a couple of spaces and newlines.

But also +1 to not trying to do that first to fix the tests. This change seems reasonable to me given that we currently compile to /development/, Rollup to the default location, and treemirror in the types, just like in lit-html, etc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and removed the "development" export conditions from the lit package since there's nothing different in those so no need to even include them in package.json. I'm still keeping the existing tsc output directory and rollup since I don't want to mess with that, and therefore "types" export will still point to ./development/*.d.ts and the /development/ directory output will be included in the npm package for those. I think that's a good compromise for now.

@Mister-Hope
Copy link

Any release schedule about this? My CI has been fallen because of it since Aug.

@augustjk
Copy link
Member Author

augustjk commented Oct 4, 2022

Any release schedule about this? My CI has been fallen because of it since Aug.

We're looking to get it out soon. Hopefully within the week!

This was referenced Oct 5, 2022
@augustjk
Copy link
Member Author

augustjk commented Oct 5, 2022

@Mister-Hope This is now published in lit@2.4.0

usergenic added a commit that referenced this pull request Nov 30, 2022
* Move the render function to the end of lit-html (#3284)

* Move the render function to the end of lit-html

Believe it or not, this is part of some work to better integrate with closure compiler's dead code elimination.

* Add an empty changeset.

* Fix empty changeset.

* Task: Do not reset task value or error on pending (#3283)

* [infra] Enable IntersectionController and PerformanceController tests (#3291)

Add intersection controller and performance controller tests to CI - skipping Safari.
Deflake Firefox intersection controller tests.

* [labs/ssr] fix Hydrating LitElements example markup (#3298)

* [labs/observers] Fix controllers not observing target if initialized after host connected (#3293)

Co-authored-by: Steve Orvell <sorvell@google.com>

* [labs/analyzer] Refactor Analyzer into better fit for use in plugins (#3288)

* Refactor context

* Make Analyzer implement AnalyzerInterface rather than has-a AnalyzerContext

* Add PackageInfo and pass to getModule

* Add changeset. Minor cleanup.

* Fix cli test

* Normalize rootDir

* Refactor PackageAnalyzer into factory

* Address feedback. Minor cleanup.

* Slack -> Discord readme (#3307)

* [@labs/gen-wrapper-react] TestOutput links to monorepo for dependencies (#3310)

* test-output points to the same react dependency

* remove types from tsconfig in labs_react

* restore multiple react versions

* [labs/cli] Lazily install and locally version localize (#2936)

* [cli] Lazily install and locally version localize

Also merge the two localize commands into one

They have just about the same deps and share some setup and teardown code, there's no win in putting them in separate modules.

* Use better assertions of no errors.

This should print out the stderr output in the case there was some.

* Fix error output

The .finally fork of the Promise.race result promise was causing an early exit from node before the ordinary uvu error handling could kick in.

* Fix failing test

It was passing locally because the cwd was set to the CLI directory, but we want to run in a fake workspace directory.

* Add an installation message when running npm install.

* Changeset

* Use try/finally instead of promise methods

* Move localize command into its own package.

* Task add onComplete and onError (#3287)

* [lit] Add "types" to package exports (#3320)

* [lit-html] Add `isServer` environment checker module (#3318)

Adds an `isServer` variable export to `lit` and `lit-html/is-server.js` which will be `true` in Node and `false` in the browser. This can be used when authoring components to change behavior based on whether or not the component is executing in an SSR context.

* [labs/analyzer] Adds support for analyzing JavaScript packages (#3304)

* Add support for analyzing JavaScript packages

* Fix customElements.define detection, add comments.

* Better comments / error handling

* Revert accidental SSR changes

* Add optional/non-null to model

* Run analyzer_test in JS. Add changeset.

* Fix gen-wrapper-angular

* Fix another inadvertant SSR change

* Address review feedback.

* Add test based on feedback.

* [labs/observers] Improve controllers value type from unknown to generic (#3294)

Fix value property of type `unknown` on exported controllers. The type of
`value` is now generic and can be inferred from the return type of your passed
in `callback`. The default callback `() => true` was removed, and is now
undefined by default.

* [labs/react] Provide explicit return type from createComponent (#3163)

* create params object

* add changeset

* update readme

* eeek, this requires generics

* found correct return type

* more refined type

* add ref typing

* adjust ref typings

* type forwarded instance

* expose types at top of file

* organize types

* no react window module

* no react window module

* add event listeners

* checkout readmes from main

* remove as casting in render

* remove anys

* create minimal JSXInterface for library

* save types

* jsxmodule

* attrubtes over htmlprops

* explicit return of element types

* move comments

* minimal references to window

* remove ref cast

* remove code changes, type only changes

* update changeset

* ideal

* roll back to minimal amount of changes

* types at top of file

* better comment

* rename userprops to element props

* add types to test refs

* add extends to exported element props type

* pause to sync

* add comments, more specific names for events

* update EventNames downstream

* include package types in tsconfig

* undo

* tests pass with no extra exports

* exposing element props successful

* wow only the exposed ReactWebComponent fails

* add react types to workspaces

* move types to dev deps

* remove artifacts from different PR

* remove rollup artifact from other PR

* declare types in test-output tsconfig

* capitals for classes

* add export to ReactWebComponent

* a/b the types array in test-output

* add test for ReactWebComponent type

* simplify test

* componentProps to ReactComponentProps

* type only test

* update description

* unblocked gen-wrapper-react

* add comment for type test

* restore modified files

* restore modified files, again

* remove types tsconfig property

* only export what's required

* remove old code

* add return type

* remove extra line in index

* [labs/observers] observed targets are re-observed when the host is reconnected (#3321)

Controllers now track all observed targets and will restore observing targets
when host is reconnected.

Fixes: #2902

* [labs/observers] Add unobserve method to ResizeController and IntersectionController (#3323)

Add unobserve method to `ResizeController` and `IntersectionController` to match native API.

Fixes: #3237

* [labs/gen-utils] Add core packages to testing install with link (#3330)

* [infra] Update changesets and package for release (#3332)

* Update changesets for release

* Update cli-localize package.json for release

* Add @lit-labs/cli-localize to changeset

* Remove gen-wrapper-angular from changesets (#3336)

* Version Packages (#3337)

* Unpin Node version for windows-tools test (#3338)

* [labs/react] introduce a options object (#2988)

* create params object

* add changeset

* update readme

* eeek, this requires generics

* found correct return type

* more refined type

* add ref typing

* adjust ref typings

* type forwarded instance

* expose types at top of file

* organize types

* no react window module

* no react window module

* more merge main

* initial params bag

* add changeset, remove commented code

* ReactOrParams

* destructure params

* update tests, react is optional

* remove optional react

* remove default react

* change is a patch

* forgot options.react

* [labs/react] Update REAMDE for function overload (#3350)

* initial commit

* add empty changeset

* [@lit-labs/router] add Routes.link tests (#3348)

* [gen-manifest] Initial impl of CEM generator (#2990)

* [gen-manifest] Initial impl of CEM generator

Reset changelog

Fix readme

* Sync with monorepo changes

* Fix comments

* Add variable declaration

* Update to changes on main.

* Fix version for gen-utils

* Fix analyzer version

* Fix and add tests for type reference serialization

* [labs/analyzer] Cache Module models based on dependencies. (#3333)

* Cache Module models based on dependencies.

* Cleanup and add changeset.

* Windows path fixes

* Normalize all the paths for Windows

* Move moduleCache from module var to Analyzer field.

* Add missing wireit input

* Add missing wireit output

* Fix typo in task README (#3385)

* Initializers are copied but separate from superclass initializers (#3374)

Initializers are copied but separate from superclass initializers, fixes #/3373.

* Example code had an h1 tag closed by an h3 tag (#3392)

I changed the h3 tag to be an h1 tag to match the other routes

* Improvements to Vue/React wrappers (#3377)

Updates react wrapper to correctly type events
Update vue wrapper
* update vite/vue deps
* properly type events
* configure defaults using the Vue convention: whenever unset, revert to default value.

* Wrapper test elements + runtime tests (#3384)

* Adds additional test elements
  * element-events: for testing events
  * element-props: for testing property types
  * element-slots: for testing slotting.
* Adds property types to angular wrapper

* [@labs/react] certain attributes should be removed when undefined or null (#3128)

* add sieve for boolean attributes

* unchange stuff that isn't required yet

* add changeset

* no sieve, use hasAttribute

* use hasOwnProperty

* boolean attributes should test as null

* pause

* let react handle the nullifies

* remove unnecessary return

* add comment, update changeset

* remove 232

* cascade logic over nested

* update comments

* don't watch for disabled

* show test updates and output

* hidden attr is alright

* passing tests

* set HTMLPrototype undefined values to empty string

* id is the special case

* add tests for properties

* update tests for properties

* remove nested iffs from set property

* format

* set as empty string

* change value, don't assign

* value as str

* remove attribute if undefined

* set value as string on htmlelement attr

* match vanilla react behavior

* order ifs by cost, comment alternatives

* forgot return

* checkpoint

* sync with example gist

* draggable is null

* checkpoint

* update tests, wrappedEl vs el

* test div against web component

* remove extra lines

* update changeset

* include unwrapped web component x-foo

* add null checks at end of attribute checks

* add comments, add undefined tests after boolean

* typo, enumerated

* add null checkes to test, add ts-expect-errors

* add test ordering

* forgot one truthy test

* [infra] Use new projectV2 object in issue workflow (#3419)

* Add lit to changeset along side reactive-element (#3422)

* Version Packages (#3423)

* Update chromedriver to 107 for benchmark tests (#3427)

* Update chromedriver to 107 for benchmark tests

* [labs/virtualizer] Fix width inheritance calculation (issue #3400) (#3424)

* Added a test to demonstrate virtualizer width inheritance bug in #3400
* Applied the fix to Virtualizer _updateView to interpret width correctly.
* Added changeset describing the fix for #3400.

* [labs/virtualizer] Export event classes through a new events.js (#3430)

* Added an events.js to export the RangeChangedEvent and VisibilityChangedEvent classes.

* Point to events.js to get the event classes now and moved the custom Range interface into there.

* Added events.js files to package.json's files property and the wireit outputs for build:ts.

* [labs/context] Rename context decorators to consume and provide (#3398)

* [@labs/react] Filter __forwardedRef in prod build (#3409)

* [labs/react] Filter __forwardedRef in prod build

* rebased from main, branched from react-forwarded-ref

* added changeset

* update ref setting

* add dunders back in

* add comments, update changeset

* iterrate userprops

Co-authored-by: Justin Fagnani <justinfagnani@google.com>

* [labs/context] Make @consume decorator work with optional fields (#3399)

* [labs/context] Rename ContextKey to Context (#3404)

* Allow ContextProvider to be added lazily and still work with ContextRoot (#3434)

* [infra] Fix npm install with version 9 (#3448)

* Fix dep on missing folder. Fixes npm install on npm 9.

* Add empty changeset

* Implement `lit init element` (#3248)

Co-authored-by: Justin Fagnani <justinfagnani@google.com>

* Logo dark mode support (#3457)

* Update logo.svg

* empty changeset

* lit logo dark mode

* add light theme too

* fix file locations

* use srcset

* slack to discord badge

* Gitignore build output files from virtualizer (#3454)

* Gitignore build output files from virtualizer
* add prettierignore files

* [labs/analyzer] Add lazy Declaration analysis, Reference dereferencing, and Superclass support (#3380)

* Fix comment

* Use NODE_OPTIONS=--enable-source-maps

* Make declarations lazy

* Analyze exports and add ability to dereference References to them

* Add superClass reference analysis

* Add changeset

* fixup! Use NODE_OPTIONS=--enable-source-maps

* Fix references to ImportTypes

* Add CEM generation to CLI

* Fix type import references

* Address review feedback.

* Fix path normalization on Windows

* Updates based on feedback.

* Add getSpecifierString to another site.

* [labs/gen-manifest] Adds `exports` and more metadata to manifest generator (#3464)

* Adds exports to manifest generator
Also fixes a few bugs in export analysis and adds better tests.

* Add `@slot`, `@cssProp`, and `@cssPart` to manifest generator

* Fix config to make JS program analysis faster.

* Add windows line ending to regex

* Add changeset

* Additional Windows line endings fix.

* Add support for parsing description, summary, & deprecated

* Add more exports support

* Emit summary & description in manifest.

* Gitignore build output files from virtualizer (#3454)

* Gitignore build output files from virtualizer
* add prettierignore files

* Add the js.map extension to the files property for events.js.

* update .prettierignore and .gitignore to include events.js.map

Co-authored-by: Peter Burns <rictic@google.com>
Co-authored-by: Elliott Marquez <5981958+e111077@users.noreply.github.com>
Co-authored-by: Andrew Jakubowicz <ajakubowicz@google.com>
Co-authored-by: Michael Potter <mgp140@gmail.com>
Co-authored-by: Steve Orvell <sorvell@google.com>
Co-authored-by: Kevin Schaaf <kschaaf@google.com>
Co-authored-by: Brian Taylor Vann <brian.t.vann@gmail.com>
Co-authored-by: Augustine Kim <augustinekim@google.com>
Co-authored-by: Lit Robot <98060554+lit-robot@users.noreply.github.com>
Co-authored-by: Nick Cipriani <nick.cipriani@gmail.com>
Co-authored-by: Brendan Baldwin <brendan@usergenic.com>
Co-authored-by: Justin Fagnani <justinfagnani@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants