Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better hydration error messages #3583

Merged
merged 2 commits into from Jan 18, 2023
Merged

Better hydration error messages #3583

merged 2 commits into from Jan 18, 2023

Conversation

justinfagnani
Copy link
Member

This gives a little more information on two hydration errors where we find either too many or no root parts when hydrating.

@changeset-bot
Copy link

changeset-bot bot commented Jan 18, 2023

🦋 Changeset detected

Latest commit: bef2914

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
lit-html Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2023

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: faster ✔ 1% - 9% (0.30ms - 2.07ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 81.80ms - 87.13ms
  • lit-html-kitchen-sink: unsure 🔍 -5% - +3% (-1.63ms - +0.92ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -4% - +5% (-0.47ms - +0.64ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -0% - +4% (-0.16ms - +1.95ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -2% - +3% (-1.16ms - +1.68ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 693.82ms - 708.16ms
  • lit-html-kitchen-sink: slower ❌ 1% - 8% (0.86ms - 6.37ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -2% - +3% (-5.47ms - +9.08ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +2% (-1.19ms - +2.12ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +0% (-6.98ms - +2.74ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 695.78ms - 706.81ms
  • reactive-element-list: unsure 🔍 -1% - +1% (-5.91ms - +4.03ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
84.19ms - 86.46ms-

update

VersionAvg timevs
808.58ms - 817.04ms-

update-reflect

VersionAvg timevs
800.57ms - 808.30ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
30.29ms - 32.11ms-unsure 🔍
-5% - +3%
-1.63ms - +0.92ms
unsure 🔍
-8% - +1%
-2.52ms - +0.43ms
tip-of-tree
tip-of-tree
30.66ms - 32.45msunsure 🔍
-3% - +5%
-0.92ms - +1.63ms
-unsure 🔍
-7% - +2%
-2.15ms - +0.77ms
previous-release
previous-release
31.09ms - 33.40msunsure 🔍
-1% - +8%
-0.43ms - +2.52ms
unsure 🔍
-2% - +7%
-0.77ms - +2.15ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
79.26ms - 83.10ms-slower ❌
1% - 8%
0.86ms - 6.37ms
unsure 🔍
-3% - +4%
-2.51ms - +3.43ms
tip-of-tree
tip-of-tree
75.60ms - 79.54msfaster ✔
1% - 8%
0.86ms - 6.37ms
-faster ✔
0% - 8%
0.15ms - 6.16ms
previous-release
previous-release
78.45ms - 82.99msunsure 🔍
-4% - +3%
-3.43ms - +2.51ms
slower ❌
0% - 8%
0.15ms - 6.16ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
21.11ms - 21.82ms-faster ✔
1% - 9%
0.30ms - 2.07ms
faster ✔
0% - 7%
0.09ms - 1.47ms
tip-of-tree
tip-of-tree
21.84ms - 23.46msslower ❌
1% - 10%
0.30ms - 2.07ms
-unsure 🔍
-3% - +6%
-0.60ms - +1.41ms
previous-release
previous-release
21.65ms - 22.84msslower ❌
0% - 7%
0.09ms - 1.47ms
unsure 🔍
-6% - +3%
-1.41ms - +0.60ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
11.86ms - 12.63ms-unsure 🔍
-4% - +5%
-0.47ms - +0.64ms
unsure 🔍
-5% - +4%
-0.55ms - +0.54ms
tip-of-tree
tip-of-tree
11.76ms - 12.56msunsure 🔍
-5% - +4%
-0.64ms - +0.47ms
-unsure 🔍
-5% - +4%
-0.65ms - +0.47ms
previous-release
previous-release
11.86ms - 12.64msunsure 🔍
-4% - +5%
-0.54ms - +0.55ms
unsure 🔍
-4% - +5%
-0.47ms - +0.65ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
262.28ms - 275.04ms-unsure 🔍
-2% - +3%
-5.47ms - +9.08ms
unsure 🔍
-3% - +3%
-8.60ms - +6.79ms
tip-of-tree
tip-of-tree
263.37ms - 270.34msunsure 🔍
-3% - +2%
-9.08ms - +5.47ms
-unsure 🔍
-3% - +1%
-8.24ms - +2.83ms
previous-release
previous-release
265.27ms - 273.86msunsure 🔍
-3% - +3%
-6.79ms - +8.60ms
unsure 🔍
-1% - +3%
-2.83ms - +8.24ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
52.69ms - 54.38ms-unsure 🔍
-0% - +4%
-0.16ms - +1.95ms
unsure 🔍
-2% - +3%
-0.98ms - +1.55ms
tip-of-tree
tip-of-tree
52.01ms - 53.27msunsure 🔍
-4% - +0%
-1.95ms - +0.16ms
-unsure 🔍
-3% - +1%
-1.75ms - +0.53ms
previous-release
previous-release
52.31ms - 54.20msunsure 🔍
-3% - +2%
-1.55ms - +0.98ms
unsure 🔍
-1% - +3%
-0.53ms - +1.75ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
107.79ms - 110.07ms-unsure 🔍
-1% - +2%
-1.19ms - +2.12ms
unsure 🔍
-2% - +1%
-1.79ms - +1.43ms
tip-of-tree
tip-of-tree
107.26ms - 109.66msunsure 🔍
-2% - +1%
-2.12ms - +1.19ms
-unsure 🔍
-2% - +1%
-2.30ms - +1.01ms
previous-release
previous-release
107.97ms - 110.25msunsure 🔍
-1% - +2%
-1.43ms - +1.79ms
unsure 🔍
-1% - +2%
-1.01ms - +2.30ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
54.44ms - 57.05ms-unsure 🔍
-4% - +2%
-2.38ms - +1.08ms
unsure 🔍
-3% - +3%
-1.42ms - +1.94ms
tip-of-tree
tip-of-tree
55.25ms - 57.53msunsure 🔍
-2% - +4%
-1.08ms - +2.38ms
-unsure 🔍
-1% - +4%
-0.65ms - +2.46ms
previous-release
previous-release
54.42ms - 56.54msunsure 🔍
-3% - +3%
-1.94ms - +1.42ms
unsure 🔍
-4% - +1%
-2.46ms - +0.65ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
837.54ms - 849.56ms-unsure 🔍
-1% - +1%
-5.89ms - +11.11ms
unsure 🔍
-1% - +1%
-7.79ms - +8.27ms
tip-of-tree
tip-of-tree
834.93ms - 846.95msunsure 🔍
-1% - +1%
-11.11ms - +5.89ms
-unsure 🔍
-1% - +1%
-10.39ms - +5.66ms
previous-release
previous-release
837.99ms - 848.63msunsure 🔍
-1% - +1%
-8.27ms - +7.79ms
unsure 🔍
-1% - +1%
-5.66ms - +10.39ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
847.70ms - 856.23ms-unsure 🔍
-1% - +1%
-4.68ms - +6.46ms
unsure 🔍
-1% - +0%
-8.34ms - +3.38ms
tip-of-tree
tip-of-tree
847.49ms - 854.67msunsure 🔍
-1% - +1%
-6.46ms - +4.68ms
-unsure 🔍
-1% - +0%
-8.76ms - +2.02ms
previous-release
previous-release
850.43ms - 858.46msunsure 🔍
-0% - +1%
-3.38ms - +8.34ms
unsure 🔍
-0% - +1%
-2.02ms - +8.76ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link
Member

@aomarks aomarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a changeset

Copy link
Member

@kevinpschaaf kevinpschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinfagnani justinfagnani merged commit 88a4017 into main Jan 18, 2023
@justinfagnani justinfagnani deleted the ssr-errors branch January 18, 2023 19:43
@lit-robot lit-robot mentioned this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants