[Refactor] prefer second .then arg over .catch

Since `.then` is always present, but `.catch` isn’t
tape-testing · Sep 21, 2023 · 135a952 · 135a952
1 parent 5ba89c9
commit 135a952
Showing 1 changed file with 13 additions and 10 deletions.
diff --git a/lib/test.js b/lib/test.js
@@ -116,18 +116,21 @@ Test.prototype.run = function run() {
         && typeof callbackReturn.then === 'function'
 	) {
 		var self = this;
-		Promise.resolve(callbackReturn).then(function onResolve() {
-			if (!self.calledEnd) {
+		Promise.resolve(callbackReturn).then(
+			function onResolve() {
+				if (!self.calledEnd) {
+					self.end();
+				}
+			},
+			function onError(err) {
+				if (err instanceof Error || objectToString(err) === '[object Error]') {
+					self.ifError(err);
+				} else {
+					self.fail(err);
+				}
 				self.end();
 			}
-		})['catch'](function onError(err) {
-			if (err instanceof Error || objectToString(err) === '[object Error]') {
-				self.ifError(err);
-			} else {
-				self.fail(err);
-			}
-			self.end();
-		});
+		);
 		return;
 	}