Propose an optional emoji version for tap-spec consumer #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Apr 4, 2020
ljharb
added a commit
that referenced
this pull request
May 25, 2020
- [Fix] `createStream`: `result` payload is not always an object (#519) - [Fix] Update RegExp for matching stack frames to handle Promise/then scenario (#516) - [readme] add `tape-repeater` (#511) - [readme] Add link to tape-player (in-process reporter) (#496) - [examples] add `ecstatic` - [Docs] add an optional emoji version for tap-spec consumer (#501) - [Deps] update `minimist`, `resolve` - [Tests] Fix simple typo, placehodler -> placeholder (#500) - [Dev Deps] update `eslint`, `falafel`, `js-yaml`
ljharb
added a commit
that referenced
this pull request
May 25, 2020
v4.13.3 - [Fix] `createStream`: `result` payload is not always an object (#519) - [Fix] Update RegExp for matching stack frames to handle Promise/then scenario (#516) - [readme] add `tape-repeater` (#511) - [readme] Add link to tape-player (in-process reporter) (#496) - [examples] add `ecstatic` - [Docs] add an optional emoji version for tap-spec consumer (#501) - [Deps] update `minimist`, `resolve` - [Tests] Fix simple typo, placehodler -> placeholder (#500) - [Dev Deps] update `eslint`, `falafel`, `js-yaml`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch Motivation
Using a terminal with emoji support, the tests output become pretty ugly. This package use different emojis instead.
Why not a PR
You may still use the original lib for your CI in case it doesn't support emojis (because it support char fallbacks), but on your local computer this version allow for a better output
Original
Patched