Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt test to V8 9.3 #562

Closed
targos opened this issue Sep 6, 2021 · 1 comment
Closed

Adapt test to V8 9.3 #562

targos opened this issue Sep 6, 2021 · 1 comment

Comments

@targos
Copy link

targos commented Sep 6, 2021

There is one test that will fail with Node.js >= 16.9.0, because V8 changed an error message:

https://github.com/substack/tape/blob/5a5a574d7b07c2c1bebda1c8cb74af9d906d178b/test/async-await.js#L265-L285

See https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2754/nodes=fedora-latest-x64/testReport/junit/(root)/citgm/tape_v5_3_1/

     # Subtest: async-bug
         not ok 1 - should be equivalent
           ---
           found:
             - TAP version 13
             - '# async-error'
             - ok 1 before throw
             - ok 2 should be strictly equal
             - 'not ok 3 TypeError: Cannot read properties of null (reading ''length'')'
             - '  ---'
             - '    operator: error'
             - '    stack: |-'
             - '      TypeError: Cannot read properties of null (reading ''length'')'
             - '          at myCode ($TEST/async-await/async-bug.js:$LINE:$COL)'
             - '          at Test.myTest ($TEST/async-await/async-bug.js:$LINE:$COL)'
             - '  ...'
             - ''
             - 1..3
             - '# tests 3'
             - '# pass  2'
             - '# fail  1'
             - ''
             - ''
           wanted:
             - TAP version 13
             - '# async-error'
             - ok 1 before throw
             - ok 2 should be strictly equal
             - 'not ok 3 TypeError: Cannot read property ''length'' of null'
             - '  ---'
             - '    operator: error'
             - '    stack: |-'
             - '      TypeError: Cannot read property ''length'' of null'
             - '          at myCode ($TEST/async-await/async-bug.js:$LINE:$COL)'
             - '          at Test.myTest ($TEST/async-await/async-bug.js:$LINE:$COL)'
             - '  ...'
             - ''
             - 1..3
             - '# tests 3'
             - '# pass  2'
             - '# fail  1'
             - ''
             - ''
           at:
             line: 265
             column: 11
             file: test/async-await.js
           stack: |
             test/async-await.js:265:11
             ChildProcess.<anonymous> (test/common.js:102:9)
             ChildProcess.emit (node:events:394:28)
             Process.ChildProcess._handle.onexit (node:internal/child_process:290:12)
           source: |
             t.same(stripFullStack(stdout), [
           ...
@ljharb
Copy link
Collaborator

ljharb commented Sep 6, 2021

(-‸ლ) this isn't even a better error message

@ljharb ljharb closed this as completed in bfeabe8 Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants