Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] Exclude fs from browser bundlers #565

Merged
merged 1 commit into from Sep 13, 2021
Merged

[meta] Exclude fs from browser bundlers #565

merged 1 commit into from Sep 13, 2021

Conversation

fregante
Copy link
Contributor

@fregante fregante commented Sep 12, 2021

As suggested in #561 (comment) and verified in #561 (comment)

In short this change will let:

  • webpack 4 users bundle without any configuration
  • webpack 5 users remove 1 line of config 馃槄
  • other bundlers to skip looking for the fs dependency altogether

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2021

Codecov Report

Merging #565 (00f21ea) into master (c837b02) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #565   +/-   ##
=======================================
  Coverage   96.49%   96.49%           
=======================================
  Files           4        4           
  Lines         627      627           
  Branches      145      145           
=======================================
  Hits          605      605           
  Misses         22       22           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update c837b02...00f21ea. Read the comment docs.

@ljharb ljharb changed the title Exclude fs from some browser bundlers [meta] Exclude fs from browser bundlers Sep 13, 2021
@ljharb ljharb merged commit 00f21ea into tape-testing:master Sep 13, 2021
@fregante fregante deleted the patch-1 branch September 13, 2021 15:27
@fregante
Copy link
Contributor Author

Thanks!

ljharb added a commit that referenced this pull request Nov 16, 2021
 - [Fix] use `file://` URLs for dynamic `import()` (#571, #559)
 - [readme] hard wraps bad, soft wraps good
 - [readme] fix markdown; github still has a rendering bug
 - [readme] add badges
 - [meta] Exclude `fs` from browser bundles (#565)
 - [Deps] update `glob`, `string.prototype.trim`
 - [Dev Deps] update `eslint`, `@ljharb/eslint-config`, `safe-publish-latest`, `array.prototype.flatmap`
 - [actions] update codecov uploader
 - [Tests] handle carriage returns in stack traces on Windows
 - [Tests] node 17+ smooshes a version number on the end of the stack trace
 - [Tests] handle v8 6.9 changing an error message
ljharb pushed a commit that referenced this pull request Jan 26, 2022
ljharb added a commit that referenced this pull request Jan 26, 2022
 - [New] add `--no-only` flag/`NODE_TAPE_NO_ONLY_TEST` (#572)
 - [New] `t.match`/`t.doesNotMatch: fail the test instead of throw on wrong input types.
 - [Fix] `bin/tape`: delay requires until needed
 - [Robustness] use cached `.test`
 - [readme] hard wraps bad, soft wraps good
 - [readme] port changes from v5
 - [meta] fix `prelint` so it does not fail outside of a git repo
 - [meta] better `eccheck` command
 - [meta] Exclude `fs` from browser bundles (#565)
 - [actions] reuse common workflows
 - [actions] update codecov uploader
 - [Deps] update `object-inspect`, `resolve`, `glob`, `is-regex`, `string.prototype.trim`
 - [Dev Deps] update `eslint`, `@ljharb/eslint-config`, `aud`, `safe-publish-latest`, `array.prototype.flatmap`
 - [Tests] handle a broken error `cause` in node 16.9/16.10
 - [Tests] handle carriage returns in stack traces on Windows
ljharb added a commit that referenced this pull request Jan 26, 2022
v4.15.0

 - [New] add `--no-only` flag/`NODE_TAPE_NO_ONLY_TEST` (#572)
 - [New] `t.match`/`t.doesNotMatch: fail the test instead of throw on wrong input types.
 - [Fix] `bin/tape`: delay requires until needed
 - [Robustness] use cached `.test`
 - [readme] hard wraps bad, soft wraps good
 - [readme] port changes from v5
 - [meta] fix `prelint` so it does not fail outside of a git repo
 - [meta] better `eccheck` command
 - [meta] Exclude `fs` from browser bundles (#565)
 - [actions] reuse common workflows
 - [actions] update codecov uploader
 - [Deps] update `object-inspect`, `resolve`, `glob`, `is-regex`, `string.prototype.trim`
 - [Dev Deps] update `eslint`, `@ljharb/eslint-config`, `aud`, `safe-publish-latest`, `array.prototype.flatmap`
 - [Tests] handle a broken error `cause` in node 16.9/16.10
 - [Tests] handle carriage returns in stack traces on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants