Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RegExp for matching stack frames to handle Promise/then scenario (fixes #515). #516

Merged
merged 1 commit into from May 20, 2020
Merged

Update RegExp for matching stack frames to handle Promise/then scenario (fixes #515). #516

merged 1 commit into from May 20, 2020

Conversation

DavidAnson
Copy link
Contributor

No description provided.

@DavidAnson
Copy link
Contributor Author

Implemented this as requested in #515.

DavidAnson
DavidAnson commented May 19, 2020
View reviewed changes
lib/test.js Show resolved Hide resolved
DavidAnson
DavidAnson commented May 19, 2020
View reviewed changes
lib/test.js Show resolved Hide resolved
DavidAnson
DavidAnson commented May 19, 2020
View reviewed changes
test/stackTrace.js Outdated Show resolved Hide resolved
DavidAnson
DavidAnson commented May 19, 2020
View reviewed changes
lib/test.js Show resolved Hide resolved
ljharb
ljharb approved these changes May 19, 2020
View reviewed changes
Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tests pass, this looks great, thanks

@ljharb
Copy link
Collaborator

ljharb commented May 19, 2020 •
edited

However, tests are failing in node 0.8 and 0.10 (and 0.6 and 0.9), which may explain a bit about the way things are done in master :-/

ljharb
ljharb requested changes May 19, 2020
View reviewed changes
test/stackTrace.js Outdated Show resolved Hide resolved
test/stackTrace.js Outdated Show resolved Hide resolved
@DavidAnson DavidAnson requested a review from ljharb May 20, 2020 03:13
@ljharb ljharb merged commit 470e43b into tape-testing:master May 20, 2020
ljharb added a commit that referenced this pull request May 25, 2020
@ljharb
v4.13.3
a861230 
 - [Fix] `createStream`: `result` payload is not always an object (#519)
 - [Fix] Update RegExp for matching stack frames to handle Promise/then scenario (#516)
 - [readme] add `tape-repeater` (#511)
 - [readme] Add link to tape-player (in-process reporter) (#496)
 - [examples] add `ecstatic`
 - [Docs] add an optional emoji version for tap-spec consumer (#501)
 - [Deps] update `minimist`, `resolve`
 - [Tests] Fix simple typo, placehodler -> placeholder (#500)
 - [Dev Deps] update `eslint`, `falafel`, `js-yaml`
ljharb added a commit that referenced this pull request May 25, 2020
@ljharb
Merge tag 'v4.13.3'
b7af113 
v4.13.3

 - [Fix] `createStream`: `result` payload is not always an object (#519)
 - [Fix] Update RegExp for matching stack frames to handle Promise/then scenario (#516)
 - [readme] add `tape-repeater` (#511)
 - [readme] Add link to tape-player (in-process reporter) (#496)
 - [examples] add `ecstatic`
 - [Docs] add an optional emoji version for tap-spec consumer (#501)
 - [Deps] update `minimist`, `resolve`
 - [Tests] Fix simple typo, placehodler -> placeholder (#500)
 - [Dev Deps] update `eslint`, `falafel`, `js-yaml`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
semver-patch: bugfixes/etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DavidAnson @ljharb