Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIRRTL] Change FIRRTL Parser to Require Commas #6791

Open
seldridge opened this issue Mar 6, 2024 · 0 comments
Open

[FIRRTL] Change FIRRTL Parser to Require Commas #6791

seldridge opened this issue Mar 6, 2024 · 0 comments
Labels
FIRRTL Involving the `firrtl` dialect

Comments

@seldridge
Copy link
Member

The FIRRTL spec changes to making commas mandatory. Previously, these were whitespace. While no changes are necessary to the FIRRTL parser in CIRCT (as it currently treats commas as whitespace and will parse a superset of the newly restricted FIRRTL), we should move towards aligning the parser with the spec.

Change the FIRRTL parser to start rejecting fun things like:

FIRRTL version 4.0.0
circuit ,Foo,,,,,,,:
  module ,,,,,,,,,Foo,,,:
    ,,,input,, a,,:UInt<1>
    ,,,output ,b,:,UInt<1>

    ,,,connect b a
@seldridge seldridge added the FIRRTL Involving the `firrtl` dialect label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FIRRTL Involving the `firrtl` dialect
Projects
None yet
Development

No branches or pull requests

1 participant