Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIRRTL] Add back owning module constraint for local targets after removing use of ExtractInstances #6812

Open
mikeurbach opened this issue Mar 12, 2024 · 0 comments

Comments

@mikeurbach
Copy link
Contributor

In #6811, we relaxed the owning module constraint for local targets. This should be safe, but is generally not something we want to do.

The problem is we have local targets to instances that have been extracted beyond the owning module boundary intentionally by ExtractInstances, but we still want to target them within the component they were originally a part of.

The change allows us to target them, and is safe, since it still requires a single instantiation site, but this extraction doesn't play well with the encapsulation of a component in general. Once we get off that approach, we should revert the above PR to restore the original constraint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant