Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESI][runtime] Make cmake-distributed header include-able #6969

Open
mortbopet opened this issue Apr 30, 2024 · 1 comment
Open

[ESI][runtime] Make cmake-distributed header include-able #6969

mortbopet opened this issue Apr 30, 2024 · 1 comment
Assignees

Comments

@mortbopet
Copy link
Contributor

Currently, https://github.com/llvm/circt/blob/main/lib/Dialect/ESI/runtime/CMakeLists.txt is written in such a way that (i presume) it's expected to be added via add_subdirectory. Instead, I think it would be better to have an esi.cmake file which can be included, or write the CMake support s.t. we can do find_library.

As a minimum, this file needs to be refactored s.t. file-paths are absolute (using ${CMAKE_CURRENT_SORCE_DIR}) and not relative (e.g. set(ESIRuntimeSources cpp/lib/Accelerator.cpp ... -> set(ESIRuntimeSources ${CMAKE_CURRENT_SORCE_DIR}/cpp/lib/Accelerator.cpp).

@teqdruid
Copy link
Contributor

Partially addressed by b51a644 and 474fc3f. ESI Runtime is now FetchContent-able. I also have a .cmake file which gets installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants