Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIRRTL][LowerXMR] Simplify now that input probes aren't supported #7031

Open
dtzSiFive opened this issue May 13, 2024 · 0 comments
Open

[FIRRTL][LowerXMR] Simplify now that input probes aren't supported #7031

dtzSiFive opened this issue May 13, 2024 · 0 comments
Labels
enhancement New feature or request FIRRTL Involving the `firrtl` dialect

Comments

@dtzSiFive
Copy link
Contributor

With input probes no longer being valid IR, this pass can be simplified.

Paths are now append-only and can be resolved in a single post-order (considering all entry points / instance-graph nodes not just the "main" top) and strictly following their flow via define and ref.sub/ref.cast operations.
(or similar/equivalent formulations, just pointing to what simplification is now possible)

Instead of needing to walk IR repeatedly until convergence (cc #5732), follow the flow of the refs along the dataflow and walk that once[1].

[1] at least once our IR supports the efficient thing here, as-is need to walk the IR to extract the requisite dataflow graph anyway, so shrug. Point is this is a simple flow along the flow of refs now (and bottom-up re:module visiting), shouldn't need to track things to resolve using information discovered later 👍.

@dtzSiFive dtzSiFive added enhancement New feature or request FIRRTL Involving the `firrtl` dialect labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request FIRRTL Involving the `firrtl` dialect
Projects
None yet
Development

No branches or pull requests

1 participant