Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HLSL] Default linkage of HLSL function should be internal #92071

Open
hekota opened this issue May 14, 2024 · 0 comments · May be fixed by #93336
Open

[HLSL] Default linkage of HLSL function should be internal #92071

hekota opened this issue May 14, 2024 · 0 comments · May be fixed by #93336
Assignees
@hekota
Labels
HLSL HLSL Language Support

Comments

@hekota
Copy link
Member

hekota commented May 14, 2024 •
edited

Default linkage of HLSL function should be internal to match DXC behavior. It is currently set to external.

This issue is blocking #92073.

AC:

  • Functions are not exported by default to match DXC behavior
  • Tests are adjusted to handle functions not being exported by default; clang's -fvisibility flag should be used if functions need to be exported
  • The default behavior is documented in the HLSL Spec
@hekota hekota changed the title [HLSL] Default linkage of HLSL function should be internal [HLSL] Default linkage of HLSL functions should be internal May 14, 2024
@hekota hekota added the HLSL HLSL Language Support label May 14, 2024
@hekota hekota mentioned this issue May 14, 2024
Open
@hekota hekota changed the title [HLSL] Default linkage of HLSL functions should be internal [HLSL] Change default linkage of functions to internal May 20, 2024
@hekota hekota changed the title [HLSL] Change default linkage of functions to internal [HLSL] Default linkage of HLSL function should be internal May 20, 2024
@hekota hekota mentioned this issue May 20, 2024
Open
@hekota hekota self-assigned this May 20, 2024
hekota added a commit to hekota/llvm-project that referenced this issue May 24, 2024
@hekota
[HLSL] Change default linkage of HLSL functions to internal
bc226af 
Fixes llvm#92071
@hekota hekota linked a pull request May 24, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hekota hekota

Labels
HLSL HLSL Language Support
Projects
HLSL Support
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[HLSL] Change default linkage of HLSL functions to internal hekota/llvm-project
2 participants
@EugeneZelenko @hekota