Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread-safety diagnostic uses wrong capability name for negative requirements #92118

Closed
apasel422 opened this issue May 14, 2024 · 1 comment · Fixed by #92277
Closed

Thread-safety diagnostic uses wrong capability name for negative requirements #92118

apasel422 opened this issue May 14, 2024 · 1 comment · Fixed by #92277
Labels
clang:analysis

Comments

@apasel422
Copy link

Example: https://godbolt.org/z/hEdfTWYPK

Note that the output from the positive requirement correctly labels the capability as xyz while the output from the negative requirement incorrectly labels the capability as mutex.
@antoniofrighetto
Copy link
Contributor

I'm taking a look, although it seems we fail at classifying the capability, defaulting to "mutex" in ClassifyDiagnostic when building the capability expression.

antoniofrighetto added a commit to antoniofrighetto/llvm-project that referenced this issue May 15, 2024
@antoniofrighetto
[clang][ThreadSafety] Skip past implicit cast in translateAttrExpr
fb668a4 
Ignore `ImplicitCastExpr` when building `AttrExp` for capability
attribute diagnostics.

Fixes: llvm#92118.
@antoniofrighetto antoniofrighetto mentioned this issue May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clang:analysis
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[clang][ThreadSafety] Skip past implicit cast in translateAttrExpr antoniofrighetto/llvm-project
3 participants
@apasel422 @EugeneZelenko @antoniofrighetto