Add missing return on nullptr check #92125
Conversation
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write If you have received no comments on your PR for a week, you can request a review If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
|
@llvm/pr-subscribers-mlir Author: Daniel Kuts (apach301) ChangesFixes #92123 Full diff: https://github.com/llvm/llvm-project/pull/92125.diff 2 Files Affected:
diff --git a/llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp b/llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp
index 88d353e89a461..92347b7b58a12 100644
--- a/llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp
+++ b/llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp
@@ -3392,8 +3392,10 @@ static bool HandleUse(TreePattern &I, TreePatternNodePtr Pat,
Record *Rec;
if (Pat->isLeaf()) {
DefInit *DI = dyn_cast<DefInit>(Pat->getLeafValue());
- if (!DI)
+ if (!DI) {
I.error("Input $" + Pat->getName() + " must be an identifier!");
+ return false;
+ }
Rec = DI->getDef();
} else {
Rec = Pat->getOperator();
diff --git a/mlir/lib/Dialect/Transform/IR/TransformOps.cpp b/mlir/lib/Dialect/Transform/IR/TransformOps.cpp
index eb09f007fbca8..a6e4e340da407 100644
--- a/mlir/lib/Dialect/Transform/IR/TransformOps.cpp
+++ b/mlir/lib/Dialect/Transform/IR/TransformOps.cpp
@@ -654,7 +654,7 @@ LogicalResult transform::ApplyConversionPatternsOp::verify() {
InFlightDiagnostic diag = emitOpError()
<< "expected default converter child op to "
"implement TypeConverterBuilderOpInterface";
- diag.attachNote(typeConverterOp->getLoc()) << "op without interface";
+ diag.attachNote(typeConverterRegion.front().front()->getLoc()) << "op without interface";
return diag;
}
// Check default type converter type.
|
apach301
force-pushed
the
fix-nullptr-deref
branch
from
caed1d5
to
0c10430
Compare
apach301
force-pushed
the
fix-nullptr-deref
branch
from
0c10430
to
b22942c
Compare
| @@ -3392,8 +3392,10 @@ static bool HandleUse(TreePattern &I, TreePatternNodePtr Pat, | |||
| Record *Rec; | |||
| if (Pat->isLeaf()) { | |||
| DefInit *DI = dyn_cast<DefInit>(Pat->getLeafValue()); | |||
| if (!DI) | |||
| if (!DI) { | |||
| I.error("Input $" + Pat->getName() + " must be an identifier!"); | |||
There was a problem hiding this comment.
Mind adding a test that covers this error message? ubsan'd builds of llvm would have caught this if we had one.
There was a problem hiding this comment.
Unfortunately I don't have input or compiled target to reproduce error - the bug was found by static analysis
Fixes #92123