Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate to from member x.cast<T>() to mlir::cast<T>(x) #3299

Closed
bjacob opened this issue May 7, 2024 · 1 comment · Fixed by #3405
Closed

migrate to from member x.cast<T>() to mlir::cast<T>(x) #3299

bjacob opened this issue May 7, 2024 · 1 comment · Fixed by #3405

Comments

@bjacob
Copy link
Contributor

bjacob commented May 7, 2024

The old-style member form is now flagged as deprecated. To avoid many warnings, we have to disable the deprecated-declaration warning. Complete the migration to mlir::cast and then un-disable the warning.
@zjgarvey zjgarvey mentioned this issue May 14, 2024
Merged
ScottTodd pushed a commit that referenced this issue May 23, 2024
@zjgarvey
Replace some depreciated uses of cast (#3343)
27169dc 
Contributing towards #3299
BaneTrifa pushed a commit to BaneTrifa/torch-mlir that referenced this issue May 24, 2024
@zjgarvey
Replace some depreciated uses of cast (llvm#3343)
2fa9594 
Contributing towards llvm#3299
@kuhar
Copy link
Member

kuhar commented May 30, 2024

Bump

@rsuderman rsuderman linked a pull request May 31, 2024 that will close this issue
[NFC] Change to *cast instead of .*cast variants #3405
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[NFC] Change to *cast instead of .*cast variants rsuderman/torch-mlir
2 participants
@bjacob @kuhar