Rule proposal: no-skip-without-comment

[Lakitna]

In my team, we made the decision that when a test is skipped for some reason that we add a short comment explaining why. We do this purely for maintenance and organisational reasons.

Doing it like this helps us with:

• Communication about which skipped tests are linked to which issue and thus when they can be unskipped.
• Knowing why tests are skipped, even if it's months later.

In reality, this often looks something like:

// SKIP pending #201
it.skip('does a thing', function() {

However, I don't always remember to add these comments. A rule will improve team consistency here.

[lo1tuma]

I think this could be an option of the existing rule no-skipped-tests.

[Lakitna]

It could, but I'd prefer it as a separate rule. I think there is value in making rules have the smallest possible scope.

[lo1tuma]

But then we could have a scenario where users enable both rules at the same time, which doesn’t seem to be a useful thing to do.

[Lakitna]

True, but the worst that can happen is getting a double error.

Besides, there are definitely people, myself included, who simply disable rules they don't like instead of looking at options.

Because of lower willingness to do research regarding these kinds of thing, I think it would be more intuitive to make it a separate rule that does exactly what it says in the name.