Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixed in v10.0.1] new rule no-empty-description definition not found in v10.0.0 ? #311

Closed
mikehardy opened this issue Dec 8, 2021 · 3 comments

Comments

@mikehardy
Copy link

I see you just released v10 and when I attempted to integrate it, it immediately fails my lint run:


/Users/mike/work/Invertase/react-native-google-ads/lib/validateAdRequestOptions.js
  1:1  error  Definition for rule 'no-empty-description' was not found  no-empty-description

/Users/mike/work/Invertase/react-native-google-ads/lib/validateAdShowOptions.js
  1:1  error  Definition for rule 'no-empty-description' was not found  no-empty-description

/Users/mike/work/Invertase/react-native-google-ads/lib/version.js
  1:1  error  Definition for rule 'no-empty-description' was not found  no-empty-description

Not sure why, as when I examine node_modules/eslint-plugin-mocha/lib I see the rule, and when I check the code I see that it looks sane.

Very confusing, I might just be doing something wrong, but perhaps others see this?

I successfully linted after adding this to my eslint config even though it makes me sad and I hope it's temporary:

    'no-empty-description': 'off',

@mikehardy
Copy link
Author

https://github.com/invertase/react-native-google-ads/ this is the repo it showed up in, it's pretty small, easy to download and run lint on, remove the rule disable, try yarn lint etc.

mikehardy added a commit to invertase/react-native-google-mobile-ads that referenced this issue Dec 8, 2021
@lo1tuma
Copy link
Owner

lo1tuma commented Dec 8, 2021

This should be fixed in v10.0.1 (see #310).

@mikehardy
Copy link
Author

Just read the PR, no wonder! Just the prefix. Thanks for helping us keep our code fresh and clean :-)

@mikehardy mikehardy changed the title new rule no-empty-description definition not found in v10 ? [fixed in v10.0.1] new rule no-empty-description definition not found in v10.0.0 ? Dec 8, 2021
Star-dev325 added a commit to Star-dev325/react-native-google-mobile-ads that referenced this issue Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants