Breaking change accidentally release in 10.4.0

[newhouse]

Hi there - love this package and thanks for all the hard work!

There is a problem with your latest release of 10.4.0 however:

• 10.4.0 of eslint-plugin-mocha added the "globals": "^14.0.0" dependency.
• globals@14.0.0 has a node engines requirement of >=18.
• eslint-plugin-mocha v10.4.0 still has an engines requirement of >=14.0.0 (though it seems like you're moving towards 20 as evidenced by what's in main).

This is an accidentally breaking change for projects (like one of ours) that are running on Node 16, with a dependency of something like "eslint-plugin-mocha": "^10.2.0"

I'm not sure what you're using from globals, but it seems like 13 is compatible with Node >=8, so you can probably just change your dependency to some version of 13 and be ok, or perhaps with minor changes.

Would you consider fixing things in a patch of some sort in the 10.x semver realm?

[lo1tuma]

Thanks for reporting. I’ve downgraded globals to 13.24.0 and made a patch release of eslint-plugin-mocha, so v10.4.1 should hopefully fix this issue. Please let me know it it works for you.

[rhysd]

Ah, thank you for the follow up. I didn't notice the minimum Node.js version. (Node.js v16 is no longer supported and everyone should migrate to v18 or later, though.)

BTW, this package specifies engines.node>=20.0.0 in package.json. What are the supported Node.js versions?

eslint-plugin-mocha/package.json

Line 6 in a936f2a

"node": ">=20.0.0"

[lo1tuma]

BTW, this package specifies engines.node>=20.0.0 in package.json. What are the supported Node.js versions?

The main branch contains unreleased breaking changes which I planning to release as part of eslint-plugin-mocha v11. But I’ve cherry-picked the changes from #349 to make another 10.x release.

[newhouse]

Thanks @lo1tuma and @rhysd !

Things look good now with ^10.14.1.

I haven't looked closely over the timing of various changes, etc, but was surprised it was not caught in the CI tests given that you had a matrix of all supported engines set up:
767d900

Anyways, thanks again!!! You can close this, IMO.