Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ’„ style : Add an "Assistant and Conversation" icon #2410

Merged
merged 9 commits into from
May 12, 2024

Conversation

RubuJam
Copy link
Contributor

@RubuJam RubuJam commented May 7, 2024

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ”จ chore
  • โšก๏ธ perf
  • ๐Ÿ“ docs

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

Add an "Assistant and Conversation" icon

ๆทปๅŠ ไธ€ไธช โ€œๅŠฉๆ‰‹ไธŽๅฏน่ฏโ€ ็š„ๅ›พๆ ‡

refs #2357

close #2365

๐Ÿ“ ่กฅๅ……ไฟกๆฏ | Additional Information

Copy link

vercel bot commented May 7, 2024

@RubuJam is attempting to deploy a commit to the LobeHub Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

๐Ÿ‘ @RubuJam

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 93.37%. Comparing base (7404f3b) to head (c21faac).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2410   +/-   ##
=======================================
  Coverage   93.37%   93.37%           
=======================================
  Files         317      317           
  Lines       18827    18827           
  Branches     1407     1406    -1     
=======================================
  Hits        17579    17579           
  Misses       1248     1248           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
lobe-chat-community โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback May 12, 2024 9:15am

@arvinxx
Copy link
Contributor

arvinxx commented May 8, 2024

image

้ขœ่‰ฒไธๅฏน๏ผŒๅฆๅค–ๆ˜ฏไธๆ˜ฏๅบ”่ฏฅๆ”ถ่ตทๆ‰ๆ˜พ็คบ๏ผŒๅฑ•ๅผ€ๅฐฑไธๆ˜พ็คบ๏ผŸ

@RubuJam RubuJam reopened this May 9, 2024
@RubuJam
Copy link
Contributor Author

RubuJam commented May 9, 2024

@arvinxx ๆ‰€ๆœ‰ๆ”น่ฟ›ๅทฒ็ปๅฎŒๆˆ๏ผŒๅฆๅค–ๆˆ‘ๅธŒๆœ›่ฟ™ไธชๅ›พๆ ‡ไธ€็›ดๅœจ๏ผŒๅ› ไธบๅŽŸๆœ‰ๆ–นๅผๅœจiPad่ฎพๅค‡ไธŠไฝฟ็”จไธไพฟ๏ผŒๅฆ‚ๆžœๅฑ•ๅผ€ๅŽไธๆ˜พ็คบ๏ผŒๅฐฑๅพˆ้šพๆŠŠๅฎƒๆ”ถ่ตท

@arvinxx All improvements have been completed. In addition, I hope that this icon will always be there, because the original method is inconvenient to use on iPad. If it does not display after expansion, it will be difficult to collapse it.

image ้ขœ่‰ฒไธๅฏน๏ผŒๅฆๅค–ๆ˜ฏไธๆ˜ฏๅบ”่ฏฅๆ”ถ่ตทๆ‰ๆ˜พ็คบ๏ผŒๅฑ•ๅผ€ๅฐฑไธๆ˜พ็คบ๏ผŸ

Copy link
Contributor

@arvinxx arvinxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , thank you!

@arvinxx arvinxx merged commit 4ba23ea into lobehub:main May 12, 2024
6 checks passed
@lobehubbot
Copy link
Member

โค๏ธ Great PR @RubuJam โค๏ธ

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
้กน็›ฎ็š„ๆˆ้•ฟ็ฆปไธๅผ€็”จๆˆทๅ้ฆˆๅ’Œ่ดก็Œฎ๏ผŒๆ„Ÿ่ฐขๆ‚จ็š„่ดก็Œฎ! ๅฆ‚ๆžœๆ‚จๅฏน LobeHub ๅผ€ๅ‘่€…็คพๅŒบๆ„Ÿๅ…ด่ถฃ๏ผŒ่ฏทๅŠ ๅ…ฅๆˆ‘ไปฌ็š„ discord๏ผŒ็„ถๅŽ็งไฟก @arvinxx ๆˆ– @canisminor1990ใ€‚ไป–ไปฌไผš้‚€่ฏทๆ‚จๅŠ ๅ…ฅๆˆ‘ไปฌ็š„็งๅฏ†ๅผ€ๅ‘่€…้ข‘้“ใ€‚ๆˆ‘ไปฌๅฐ†ไผš่ฎจ่ฎบๅ…ณไบŽ Lobe Chat ็š„ๅผ€ๅ‘๏ผŒๅˆ†ไบซๅ’Œ่ฎจ่ฎบๅ…จ็ƒ่Œƒๅ›ดๅ†…็š„ AI ๆถˆๆฏใ€‚

@lobehubbot
Copy link
Member

๐ŸŽ‰ This PR is included in version 0.157.2 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€

@arvinxx
Copy link
Contributor

arvinxx commented May 13, 2024

@RubuJam ๆƒณไบ†ๆƒณ่ฟ™ไธช PR ่ƒฝไธ่ƒฝๅ†ๆ–ฐๅผ€ไธ€ไธช PR ไผ˜ๅŒ–ไธ‹๏ผŒๅช้’ˆๅฏน Pad ็ณปๅˆ—็š„่ฎพๅค‡ๅฑ•็คบ่ฟ™ไธชๆŒ‰้’ฎ๏ผŸ

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. ๐Ÿ‘ฏ๐Ÿ‘ญ๐Ÿป๐Ÿง‘โ€๐Ÿคโ€๐Ÿง‘๐Ÿ‘ซ๐Ÿง‘๐Ÿฟโ€๐Ÿคโ€๐Ÿง‘๐Ÿป๐Ÿ‘ฉ๐Ÿพโ€๐Ÿคโ€๐Ÿ‘จ๐Ÿฟ๐Ÿ‘ฌ๐Ÿฟ


@RubuJam I thought about this PR. Can I open a new PR to optimize it and display this button only for Pad series devices?

@RubuJam
Copy link
Contributor Author

RubuJam commented May 13, 2024

ๅฏไปฅๆ˜ฏๅฏไปฅ๏ผŒไธ่ฟ‡Discord้‡ŒไนŸๆœ‰ไบบ่ฏดๅŽŸๆœ‰็š„ไผธ็ผฉๆŒ‰้’ฎไธๆ–นไพฟ๏ผŒๅคชๅฐไบ†

@RubuJam ๆƒณไบ†ๆƒณ่ฟ™ไธช PR ่ƒฝไธ่ƒฝๅ†ๆ–ฐๅผ€ไธ€ไธช PR ไผ˜ๅŒ–ไธ‹๏ผŒๅช้’ˆๅฏน Pad ็ณปๅˆ—็š„่ฎพๅค‡ๅฑ•็คบ่ฟ™ไธชๆŒ‰้’ฎ๏ผŸ

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. ๐Ÿ‘ฏ๐Ÿ‘ญ๐Ÿป๐Ÿง‘โ€๐Ÿคโ€๐Ÿง‘๐Ÿ‘ซ๐Ÿง‘๐Ÿฟโ€๐Ÿคโ€๐Ÿง‘๐Ÿป๐Ÿ‘ฉ๐Ÿพโ€๐Ÿคโ€๐Ÿ‘จ๐Ÿฟ๐Ÿ‘ฌ๐Ÿฟ


Yes, yes, but some people in Discord said that the original retractable button is inconvenient and too small.

@RubuJam I thought about this PR. Can I open a new PR to optimize it and display this button only for Pad series devices?

TheNameIsNigel pushed a commit to TheNameIsNigel/lobe-chat that referenced this pull request May 15, 2024
* style:Add an "Assistant and Conversation" icon

* ๐Ÿ’„ style : Add an "Assistant and Conversation" icon

* ๐Ÿ’„ style: Add an "Assistant and Conversation" icon

* ๐Ÿ’„ style : Add an `Assistant and Conversation` icon

* ๐Ÿ’„ style : Add an `Assistant and Conversation` icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening and Closing Sidebar via Icon Buttons
3 participants