Lack of set function - porting proposal

[willypuzzle]

I noted the lack of a set function (as here). I built a sort of set function in a project of mine. At the moment it works only on array, what do you think if I make a porting of my function on your project?
What are your general guidelines to make a pull request? Do you have any suggest?
Best Regards
Domenico Rizzo

[pierredup]

@willypuzzle That would be great if you can create a PR.

Some useful info:

• Delete the src/compiled.php file while creating the function and adding the unit tests
• When you have completed the function and tests, run bin/compile before submitting the PR

Other than that, there are no other guidelines. You can create the PR and we can continue the discussion from there

[punit-kulal]

doesn't he also need to run the php-cs-fixer ??

[cube-dan]

@pierredup, @willypuzzle,

It looks like there’s a baseSet method defined here: https://github.com/lodash-php/lodash-php/blob/master/src/internal/baseSet.php

Is this as simple as adding a set.php as a next door neighbor of get.php?