Skip to content
This repository has been archived by the owner on Sep 16, 2023. It is now read-only.

Breaks when using "cwd" and "id" config options #184

Open
danny-andrews opened this issue Aug 8, 2017 · 1 comment
Open

Breaks when using "cwd" and "id" config options #184

danny-andrews opened this issue Aug 8, 2017 · 1 comment
Labels

Comments

@danny-andrews
Copy link
Contributor

This plugin gives TypeError: src/components/PasswordReset/PasswordReset.jsx: Cannot read property 'forEach' of undefined when using cwd and id.
Example:

{
  "plugins": [["lodash", { "id": ["material-ui", "redux-form-material-ui"], "cwd": "./deep/dir" }]]
}

After doing some digging, it appears this commit caused the regression.

This is because the first time we call config is here (where cwd defaults to process.cwd()). The second time is here where cwd is whatever you set it in .baberc, so we purge module cache. However, the old ids are still there and we try to loop over them here.

I'd be happy to make a PR once it's verified this is a bug, and that the offending commit can't just be reverted as a fix.

@danny-andrews danny-andrews changed the title Breaks when using "cwd" and "id" Breaks when using "cwd" and "id" config options Aug 8, 2017
@danny-andrews
Copy link
Contributor Author

danny-andrews commented Aug 8, 2017

p.s. You can reproduce this error by changing:

'plugins': [[plugin, { 'id': lodashId }]]`

to

'plugins': [[plugin, { 'id': lodashId, 'cwd': './' }]]

here

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

2 participants