Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean error message for singular fields after unmount #3385

Merged
merged 2 commits into from Jul 8, 2021

Conversation

logaretm
Copy link
Owner

@logaretm logaretm commented Jul 8, 2021

What

This PR fixes #3384 and formvuelate/formvuelate#210

@codecov-commenter
Copy link

Codecov Report

Merging #3385 (5a35b0b) into main (cfe45ba) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3385   +/-   ##
=======================================
  Coverage   96.69%   96.70%           
=======================================
  Files          65       65           
  Lines        1604     1607    +3     
  Branches      386      387    +1     
=======================================
+ Hits         1551     1554    +3     
  Misses         52       52           
  Partials        1        1           
Impacted Files Coverage Δ
packages/vee-validate/src/useForm.ts 98.98% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfe45ba...5a35b0b. Read the comment docs.

@logaretm logaretm merged commit 4e81cce into main Jul 8, 2021
@logaretm logaretm deleted the fix/3384-clean-error-messages branch July 8, 2021 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unmounted fields error messages are not removed
2 participants